Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues identified by Clang Tidy #43

Merged
merged 2 commits into from Sep 16, 2020
Merged

Conversation

rianquinn
Copy link
Member

Now that we have a bunch of checks in Clang Tidy for checking
for AUTOSAR compliance, these checks found a number of issues
with our implementation of the BSL. This patch addresses a
number of these issues, but is really just the start of a much
larger effort to get this code more into compliance as we better
define how we want to address AUTOSAR and ASIL compliance.

Now that we have a bunch of checks in Clang Tidy for checking
for AUTOSAR compliance, these checks found a number of issues
with our implementation of the BSL. This patch addresses a
number of these issues, but is really just the start of a much
larger effort to get this code more into compliance as we better
define how we want to address AUTOSAR and ASIL compliance.
@codecov
Copy link

codecov bot commented Aug 14, 2020

Codecov Report

Merging #43 into master will decrease coverage by 0.90%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##            master      #43      +/-   ##
===========================================
- Coverage   100.00%   99.09%   -0.91%     
===========================================
  Files           55       57       +2     
  Lines         1801     2205     +404     
===========================================
+ Hits          1801     2185     +384     
- Misses           0       20      +20     
Impacted Files Coverage Δ
include/bsl/fmt.hpp 88.23% <0.00%> (-11.77%) ⬇️
include/bsl/basic_string_view.hpp 97.30% <0.00%> (-2.70%) ⬇️
include/bsl/safe_integral.hpp 98.67% <0.00%> (-1.33%) ⬇️
include/bsl/span.hpp 99.29% <0.00%> (-0.71%) ⬇️
include/bsl/fmt_options.hpp 99.34% <0.00%> (-0.66%) ⬇️
include/bsl/byte.hpp 100.00% <0.00%> (ø)
include/bsl/move.hpp 100.00% <0.00%> (ø)
include/bsl/swap.hpp 100.00% <0.00%> (ø)
include/bsl/array.hpp 100.00% <0.00%> (ø)
include/bsl/debug.hpp 100.00% <0.00%> (ø)
... and 44 more

@rianquinn rianquinn merged commit 8c2df11 into Bareflank:master Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant