Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Military outpost building grid strength of 0 does not save #89

Open
Tsunder opened this issue Aug 28, 2021 · 1 comment
Open

Military outpost building grid strength of 0 does not save #89

Tsunder opened this issue Aug 28, 2021 · 1 comment

Comments

@Tsunder
Copy link
Contributor

Tsunder commented Aug 28, 2021

setting grid strength of 0 breaks the level tracker for MO

level reverts to ? as soon as building overview is opened?
@Tsunder Tsunder mentioned this issue Aug 28, 2021
Open
@Tsunder
Copy link
Contributor Author

Tsunder commented Aug 28, 2021

seems to be caused by building level 0 evaluating to false in b.level ?

Bookkeeper/chrome/overview.js

Line 343 in ab00c69

b.level ? rvalue = b.level.toLocaleString( 'en' ) : null;

fixed in my fork by using

!isNaN(b.level) ?

https://github.com/Tsunder/Bookkeeper/blob/f9d4f2c15d30656bcc4ae08c416bf2bf76ef4970/chrome/overview.js#L354

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Tsunder