Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface IAsyncSweetAlertService: public instead of protected #2183

Closed
janbensch opened this issue Nov 17, 2022 · 0 comments · Fixed by #2221
Closed

Interface IAsyncSweetAlertService: public instead of protected #2183

janbensch opened this issue Nov 17, 2022 · 0 comments · Fixed by #2221

Comments

@janbensch
Copy link

Is your feature request related to a problem? Please describe.
Both public classes SweetAlertService and SweetAlertMixin implement the protected interface IAsyncSweetAlertService. For unit testing our razor component we use bUnit. A convinient possibility for simulate the confirming oder denying the SweetAlert popup could be using Moq. But mocking a protected or private interface is not supported.

Describe the solution you'd like
Change the access modifier of the interface IAsyncSweetAlertService to public, if there is no special reason for the interface to be protected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant