New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI: Parser-based highlighting #949

Open
dirkk opened this Issue May 8, 2014 · 3 comments

Comments

Projects
None yet
2 participants
@dirkk
Contributor

dirkk commented May 8, 2014

The syntax highlighting goes wrong when there is a single " or ' present in the XML within the GUI editor. Obviously the editor expects a closing element, but this is not required by XML.

See attached screenshot:
screenshot from 2014-05-08 11 11 24

@dirkk dirkk added gui labels May 8, 2014

@ChristianGruen

This comment has been minimized.

Member

ChristianGruen commented May 8, 2014

In order to solve this, we have to advance from token highlighting to parser-based highlighting; otherwise, we’ll have no idea what’s currently being displayed. This is why I have changed the subject of this issue.

@ChristianGruen ChristianGruen changed the title from Syntax highlighting when " or ' are present in XML to GUI: Parser-based highlighting May 8, 2014

@ChristianGruen ChristianGruen added feature and removed bug labels May 8, 2014

@ChristianGruen

This comment has been minimized.

Member

ChristianGruen commented Sep 19, 2014

I merged this issue with #725...

When having overflowing text without breaks the editor hides the text using Linux (Fedora 19). I would expect either a scrollbar or automatic line breaks. See the attached screenshot for an example

screenshot from 2013-07-11 23 10 00

@ChristianGruen ChristianGruen modified the milestones: 8.7, 8.6, HOLD Dec 7, 2016

@ChristianGruen

This comment has been minimized.

Member

ChristianGruen commented Mar 1, 2017

Copied from #1426:


I just stumbled over a minor bug in the editor. If you use the following query. It is somebit confusing, because the editor highlights (: not a comment :) as comment (cyan) but acutally it should be hightlighted as text (black).

let $x := <a>(: not a comment:)</a>
return $x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment