Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animate already loaded images when using gappless playback #19

Merged
merged 2 commits into from Nov 30, 2021

Conversation

renefloor
Copy link
Collaborator

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Bug fix

⤵️ What is the current behavior?

The image widget doesn't show the placeholder when the image is already loaded in memory.

🆕 What is the new behavior (if this is a feature change)?

The image widget does show the placeholder when the image is already loaded, but the placeholder is the previous image and gapless playback is enabled.

💥 Does this PR introduce a breaking change?

No

🐛 Recommendations for testing

Test in real life situations

📝 Links to relevant issues/docs

Fixes Baseflow/flutter_cached_network_image#625

🤔 Checklist before submitting

  • All projects build
  • Follows style guide lines
  • Relevant documentation was updated
  • Rebased onto current develop

@renefloor
Copy link
Collaborator Author

@Kavantix can you try if this fixes your issue? You should be able to test this with cachednetworkimage using dependency overrides.

@codecov
Copy link

codecov bot commented Aug 2, 2021

Codecov Report

Merging #19 (577229b) into develop (a89e995) will decrease coverage by 2.95%.
The diff coverage is 0.00%.

❗ Current head 577229b differs from pull request most recent head d8c2bb2. Consider uploading reports for the commit d8c2bb2 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #19      +/-   ##
===========================================
- Coverage    46.38%   43.42%   -2.96%     
===========================================
  Files            8        8              
  Lines          235      251      +16     
===========================================
  Hits           109      109              
- Misses         126      142      +16     
Impacted Files Coverage Δ
lib/src/image/fade_widget.dart 2.38% <0.00%> (-1.07%) ⬇️
lib/src/image/image.dart 46.37% <0.00%> (-2.11%) ⬇️
lib/src/image/image_handler.dart 61.79% <0.00%> (-0.71%) ⬇️
lib/src/errors.dart 33.33% <0.00%> (+2.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a89e995...d8c2bb2. Read the comment docs.

@Kavantix
Copy link

Kavantix commented Oct 1, 2021

Seems to work nicely! @renefloor

@renefloor renefloor merged commit 42d721c into develop Nov 30, 2021
@renefloor renefloor deleted the bugfix/animate-loaded-images branch November 30, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fading between images doesnt work when they are in the memory cache
2 participants