Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox and Safari support #25

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

stephank
Copy link

@stephank stephank commented Dec 15, 2020

This PR adds support for Firefox.

  • Firefox currently doesn't support declarativeContent, but I've added page_action.show_matches. Though, maybe it's a bit broader than what background.js matched, also matching the meet.google.com landing page, I think? (But if this is okay, then maybe background.js is now obsolete?)

  • I switched from options_page to options_ui, because that's supported by both. I also removed the <h1> and logo from the options page to make it more compact. Specifically, Firefox has a fixed-width container in extension preferences that the logo was scaled to, causing lots of blur.

  • To test storage in Firefox, you have to set an extension ID. I improvised here, but don't know what requirements Mozilla sets for this. Feel free to change before publishing. 馃檪

Chrome page action:
Screenshot 2020-12-15 at 17 29 45

Firefox page action:
Screenshot 2020-12-15 at 17 34 07

Chrome preferences:
Screenshot 2020-12-15 at 17 21 33

Firefox preferences:
Screenshot 2020-12-15 at 17 23 51

@stephank
Copy link
Author

stephank commented Dec 23, 2020

This also works nicely in Safari, so I've added an Xcode project. Though, to publish it, someone will have to be in the (paid) Apple developer program.

To test locally, make sure you're on Safari 14, enable the Develop menu in Preferences -> Advanced, and from the 'Develop' menu select 'Allow Unsigned Extensions'. (This setting is reset every time Safari starts.) You can then build and run the app from Xcode and it should just work.

(EDIT: Alternatively, set a Team on the app and extension targets. This can also be a free personal team, as long as you have an Appe ID, which will work on your own devices. Downside is that this is part of project.pbxproj, which is in git.)

One thing I've noticed about Safari is that it asks separate for permission to access meet.google.com. This is only visible as a tiny 鈿狅笍 on the toolbar button of the extension. If the button is removed from the toolbar, it appears there's no feedback at all.

I've not fiddled with the code, so not sure if the toolbar button is supposed to be the page action or options UI. It's doesn't really seem to honour show_matches, and is just always visible (unless hidden by the user). The popup looks nice, but I've noticed clicking 'Preferences' on the extension just opens options.html in a tab. Could be better, maybe.

Screenshot 2020-12-23 at 10 11 03

@stephank stephank changed the title Firefox support Firefox and Safari support Jan 5, 2021
@FlorianWendelborn
Copy link

Any news on getting this merged? It鈥檚 important to support alternatives to Google鈥檚 spyware

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants