Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSVLint crashes Notepad++ with a CSV file open and running editor.getProperty('qwerty') in PythonScript console #25

Closed
shriprem opened this issue May 24, 2022 · 0 comments · Fixed by #27
Labels
bug Something isn't working

Comments

@shriprem
Copy link
Contributor

shriprem commented May 24, 2022

Using

Notepad++ version 8.4.1 with only these two plugins installed:

  1. CSVLint version 0.4.5.1
  2. PythonScript version 2.0.0.0

Steps to Replicate

  1. Open a CSV file in Notepad++ 8.4.1. The CSV file is colorized as expected by the CSVLint plugin.
  2. Open PythonScript console.
  3. Enter a command in console to set a property value. Example: editor.setProperty('TESTING', 'Hello, World!')
  4. Now, enter a command in the console to query that property value. Example: editor.getProperty('TESTING')
  5. Notepad++ will crash with no messages. The screenshot below was taken just prior to pressing ENTER with the editor.getProperty('TESTING') command.

image

Additional Info

This issue does not occur when tested with Notepad++ version 8.3.3, CSVLint v0.4.5, PythonScript v2.0.0.0.

The screenshot when similar steps work fine with the prior version of CSVLint and Notepad++.

image

You will notice that with Notepad++ version 8.3.3 & CSVLint v0.4.5, I also have the Fixed Width Data Visualizer plugin side panel open. In fact, I am the author of the FWDataViz plugin.

Recently, it came to my notice that in Notepad++ v8.4.1, with the FWDataViz side panel open, if I opened a CSV file, NPP would crash. I did some debugging with my plugin's source code and determined that the cause for the crash was at the point when my plugin issued a SCI_GETPROPERTY SendMessage to Scintilla. To confirm that the plugin at issue is CSVLint, I was able to reproduce the crash without the FWDataViz plugin, and with just the PythonScript plugin by issuing the editor.getProperty('TESTING') command while a CSV file was open in the editor.

Also, this crash does not occur when a different file type than a CSV file is the active document in the NPP editor when I issue the editor.getProperty('TESTING') command. In the screenshot below note that a CSV file is actually open in the first tab.

image

@shriprem shriprem changed the title CSVLint crashes Notepad++ with a CSV file open and running editor.getProperty('qwerty') in PythonScript console CSVLint crashes Notepad++ with a CSV file open and running editor.getProperty('qwerty') in PythonScript console May 30, 2022
@BdR76 BdR76 closed this as completed in #27 Jun 1, 2022
@BdR76 BdR76 added the bug Something isn't working label Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants