Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save statically once the media fields #66

Open
MaximeCulea opened this issue Mar 28, 2018 · 3 comments
Open

Save statically once the media fields #66

MaximeCulea opened this issue Mar 28, 2018 · 3 comments

Comments

@MaximeCulea
Copy link
Contributor

In each helper, we duplicate code and reuse the same "helper" to get possible ACF media fields to work with.

So we could move and refactor recursive_get_post_media_fields into admin/main to be triggered on acf_save_post action.

This will cause to check fields once and save somewhere as static to faster/easier reuse into helpers.

@herewithme your thought ?

@herewithme
Copy link
Member

@MaximeCulea 100% agree.
But I'm not sure that we should invest time on the current format because ACF should be totally outsourced in an addon.

@MaximeCulea
Copy link
Contributor Author

Let's do things step by step ;)
We should have done it here #51 (comment) :p
Anyway I created an issue #68 to focus on this refactoring.

@herewithme
Copy link
Member

Yes, complementary subject.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants