Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'entryValidateSignupCode' method is being called regardless of whether or not showSignupCode is true or false #69

Closed
geekyme opened this issue Feb 6, 2014 · 5 comments
Assignees
Labels
Milestone

Comments

@geekyme
Copy link

geekyme commented Feb 6, 2014

This is an issue follow up from #68 . After we tried to make the templates appear by using AccountsEntry.settings instead of AccountsEntry.config, we noticed the 'Signup code is incorrect' error appearing regardless of whether we set signupCode in the configurations.

please help!

@pmcpinto
Copy link

pmcpinto commented Feb 6, 2014

I'm having the same problem. Another problem is that the form field for the username doesn't appear.

@dkoo761
Copy link
Contributor

dkoo761 commented Feb 7, 2014

This is a blocker. No one can signup via email unless a signup code is used (which we're not using). Will try downgrading and using 0.4.4 until this is fixed.

@ryw ryw added the bug label Feb 8, 2014
@ryw ryw added this to the Next release milestone Feb 8, 2014
@ryw ryw self-assigned this Feb 8, 2014
@queso
Copy link
Contributor

queso commented Feb 9, 2014

I will try to push out a fix for this today via 0.5.3...

@dkoo761
Copy link
Contributor

dkoo761 commented Feb 9, 2014

Thanks @queso, that would be awesome! I was going to try fixing it myself and submitting a PR but the commit that broke it had a lot of stuff in it and without a test suite or thorough understanding of the design I didn't want to make things worse :)

@queso
Copy link
Contributor

queso commented Feb 11, 2014

Fixed in master via #80. Will make it in to 0.5.4.

@queso queso closed this as completed Feb 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants