Remove dependecy on git
#1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Retrieving the version of `grafana-dashboard-manager` for the purpose of logging should not require that you are running inside of the git repository, or require you to run via `poetry` to succeed. I have switched to using `importlib.metadata` from the stdlib to retrieve the package metadata which contains the version number. Signed-off-by: Christian Witts <cwitts@gmail.com>
|
Both are fair points. Thanks for giving this a go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retrieving the version of
grafana-dashboard-managerfor thepurpose of logging should not require that you are running
inside of the git repository, or require you to run via
poetryto succeed.
I have switched to using
importlib.metadatafrom the stdlib toretrieve the package metadata which contains the version number.
Signed-off-by: Christian Witts cwitts@gmail.com