-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loosen type requirement for insert_many()
?
#591
Comments
Hi @mikeckennedy , |
Thanks Roman. I appreciate that. It's no big deal but something that come up as I'm working on the new course. :) |
Types mistakes in libraries can annoy more than runtime bugs, as IDEs highlight them prominently :D Thank you for the catch! |
It will be fixed in #669 |
This issue is stale because it has been open 30 days with no activity. |
This issue was closed because it has been stalled for 14 days with no activity. |
Hey. This is low priority, however, could be worth doing.
On
Document.insert_many
the parameter documents is of typelist[Document]
. Would it be reasonable to make that any iterable of document rather than strictly list? For example, would a tuple or set of documents work?There are probably other, related methods with the same situation taking a list of documents. For example, on
beanie_init
the models list there is also a list rather than iterable.The text was updated successfully, but these errors were encountered: