Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default focus on login page #406

Closed

Conversation

arinchaik
Copy link
Contributor

Describe your changes

closes #336

  • add default focus on login page

Screenshots

Screen Shot 2566-08-16 at 15 54 36

@vercel
Copy link

vercel bot commented Aug 16, 2023

@arinchaik is attempting to deploy a commit to the Team Bearstudio Team on Vercel.

A member of the Team first needs to authorize it.

@sonarcloud
Copy link

sonarcloud bot commented Aug 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@@ -49,6 +49,7 @@ export const LoginForm = ({
label={t('auth:data.username.label')}
required={t('auth:data.username.required')}
formatValue={(v) => v?.toLowerCase().trim()}
autoFocus
Copy link
Contributor

@FabienEssid FabienEssid Aug 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be careful, in the issue it is written "not on a mobile device", I'm not sure autoFocus runs only on desktop mode
Chakra UI provides you ways to know on which device you are running the app using useBreakpointValue hook. There is an example of this hook in DateSelectorPicker component

@ntatoud
Copy link
Contributor

ntatoud commented May 22, 2024

This was closed because the branch was outdated. We now use React Hook Form for forms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default focus on login page
3 participants