Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix datatype docs #198

Merged
merged 1 commit into from Dec 6, 2022
Merged

fix: fix datatype docs #198

merged 1 commit into from Dec 6, 2022

Conversation

elsapet
Copy link
Contributor

@elsapet elsapet commented Dec 6, 2022

Description

Update datatypes.js to handle updated structure of category grouping JSON
Note: categories can now be in more than one group, so there will be some duplicate displays (e.g. "Medical and Health" appears in PHI, Sensitive, and Personal Data groups)

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@elsapet elsapet added documentation Improvements or additions to documentation echoes/initiative: curio labels Dec 6, 2022
Copy link
Contributor

@markmichon markmichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll handle the ID clashes for table of contents links in the theme PR since it already changes those lines.

@elsapet elsapet marked this pull request as ready for review December 6, 2022 15:04
@elsapet elsapet merged commit 8b6fc2a into main Dec 6, 2022
@elsapet elsapet deleted the fix/fix-datatype-docs branch December 6, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants