Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve jsonlines support #742

Merged
merged 4 commits into from Mar 6, 2023
Merged

feat: improve jsonlines support #742

merged 4 commits into from Mar 6, 2023

Conversation

vjerci
Copy link
Contributor

@vjerci vjerci commented Mar 6, 2023 •
edited

Description

Adds our own implementation of jsonlines with maximum token size of 5 MB, and removes jsonlines library dependency

Related

#718

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@vjerci vjerci marked this pull request as ready for review March 6, 2023 13:11
@vjerci vjerci merged commit 97e8e40 into main Mar 6, 2023
@vjerci vjerci deleted the feat/jsonlines branch March 6, 2023 13:26
@cfabianski cfabianski changed the title feat: add jsonlines feat: improve jsonlines support Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elsapet elsapet elsapet approved these changes

@cfabianski cfabianski Awaiting requested review from cfabianski

@gotbadger gotbadger Awaiting requested review from gotbadger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vjerci @elsapet