Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight mask optimization #1

Open
kgrabs opened this issue Aug 7, 2020 · 3 comments
Open

Slight mask optimization #1

kgrabs opened this issue Aug 7, 2020 · 3 comments

Comments

@kgrabs
Copy link

kgrabs commented Aug 7, 2020

For L134 it's a little faster to use the built-in parameter scale=2. The results are not exact but are ±1 with integer formats so that can be chalked up to rounding errors.

A quick test with ffms2 video input gave me

  • 264fps vs 285fps in 8 bit
  • 211fps vs 241fps in 16 bit
  • 150fps vs 191fps in 32 bit
@DJATOM
Copy link
Member

DJATOM commented Aug 7, 2020

You can put external whateveryouwant mask clip and it will have zero overhead against internal one.
The bottleneck of this script is not a mask anyway, but eedi3.

@kgrabs
Copy link
Author

kgrabs commented Aug 8, 2020

Yeah that's more or less why I didn't bother to make it a PR, but it wouldn't hurt to add it in next time there's a meaningful update.

@DJATOM
Copy link
Member

DJATOM commented Aug 8, 2020

I'll probably break things once again and allow to pass kwargs into filters in the next updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants