Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model is rewritten for each variant #21

Closed
Beatso opened this issue Jul 24, 2020 · 1 comment
Closed

Model is rewritten for each variant #21

Beatso opened this issue Jul 24, 2020 · 1 comment
Labels
rejected This will not be worked on

Comments

@Beatso
Copy link
Owner

Beatso commented Jul 24, 2020

Description

The model for each variant of a block is the vanilla model, but with the texture changed to the relevant variated texture.

Solution

Instead, it should reference the vanilla model as a parent, and replace the relevant texture(s).
This would also make the pack a lot more compatible with other packs that might change the model of blocks.

@Beatso Beatso added bug Something isn't working coming soon labels Jul 24, 2020
@Beatso Beatso added this to the v5.0 Cleanup milestone Jul 24, 2020
@Beatso Beatso self-assigned this Jul 24, 2020
@Beatso Beatso removed the bug Something isn't working label Jul 24, 2020
@Beatso
Copy link
Owner Author

Beatso commented Jul 27, 2020

There is absolutely no reason to do this. It will still be incompatible.

@Beatso Beatso closed this as completed Jul 27, 2020
@Beatso Beatso added rejected This will not be worked on and removed coming soon labels Jul 27, 2020
@Beatso Beatso removed this from the v5.0 milestone Aug 31, 2020
@Beatso Beatso removed their assignment Sep 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rejected This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant