Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecations #110

Merged
merged 3 commits into from
Jul 3, 2020
Merged

Remove deprecations #110

merged 3 commits into from
Jul 3, 2020

Conversation

keichinger
Copy link
Contributor

@keichinger keichinger commented Jul 1, 2020

Q A
BC breaks? yes
New feature? no
Improvement? no
Bug fix? no
Deprecations? no
Docs PR missing

@keichinger
Copy link
Contributor Author

The CI is currently failing since we want to return a BundleExtension from within BecklynRadBundle::getContainerExtension(). That class no longer exists in the current bundle and we want to avoid taking a dependency on becklyn/rad-bundles here.

Should we keep that class inside the bundle and just mark it as @internal or what is your plan, @apfelbox?

@apfelbox
Copy link
Contributor

apfelbox commented Jul 2, 2020

Why do we want to avoid the dependency here?

Jannik Zschiesche and others added 3 commits July 2, 2020 11:44
Add `.form-row` to top level form errors
# Conflicts:
#	CHANGELOG.md
@apfelbox apfelbox merged commit 0907473 into 8.x Jul 3, 2020
@apfelbox apfelbox deleted the next branch July 3, 2020 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants