Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set up CI #39

Closed
3 tasks done
orbeckst opened this issue Feb 26, 2016 · 11 comments
Closed
3 tasks done

set up CI #39

orbeckst opened this issue Feb 26, 2016 · 11 comments
Assignees
Milestone

Comments

@orbeckst
Copy link
Member

orbeckst commented Feb 26, 2016

Once we have a tests infrastructure in place #23, we need

  • Travis CI
  • coverage
  • add test and coverage badges to README
@orbeckst orbeckst added the tests label Feb 26, 2016
@orbeckst orbeckst self-assigned this Feb 26, 2016
@orbeckst orbeckst added this to the 0.5 milestone Feb 26, 2016
@orbeckst orbeckst changed the title set-up CI set up CI Feb 26, 2016
@orbeckst
Copy link
Member Author

orbeckst commented Apr 8, 2016

For most of the tests we need to install Gromacs as well. This should be possible through aptitude on the containerized Travis infrastructure.

I don't know if it's possible to pull in newer packages into a 14.04 machine. Gromacs 4.6.5 will be easy, all the other... we will see. It would be great, though, to have a test matrix with different Gromacs installations.

@dotsdl
Copy link
Collaborator

dotsdl commented Apr 11, 2016

We can use conda. There are builds provided by acellera: https://anaconda.org/acellera/gromacs

@orbeckst
Copy link
Member Author

@dotsdl can you add the travis stuff from MDPOW? This seems to be almost working.

@dotsdl
Copy link
Collaborator

dotsdl commented May 24, 2016

Yes. I'll convene with @ianmkenney and we'll slay this one. :D

@orbeckst orbeckst modified the milestones: 0.5, 0.6 May 24, 2016
@orbeckst orbeckst assigned dotsdl and unassigned orbeckst May 24, 2016
@dotsdl
Copy link
Collaborator

dotsdl commented May 25, 2016

We now have working CI, but some of the tests are failing. Haven't dug into fixing these yet; check the test output for starting points: https://travis-ci.org/Becksteinlab/GromacsWrapper

Coverage reads at 88%. Not bad, but I guess we cheat a bit since we generate many classes dynamically.

@orbeckst
Copy link
Member Author

@dotsdl : I don't see the coverage at https://codecov.io/gh/Becksteinlab/GromacsWrapper — is this because codecov is only ran when the tests pass?

And the output from travis seems to indicate that the 88% coverage are the coverage in the test files, not in the code itself.

I added the badges to the README but until coverage shows up in codecov I will leave this issue open.

@dotsdl
Copy link
Collaborator

dotsdl commented May 25, 2016

@orbeckst ah sorry, didn't look closely enough at what was included in coverage. I'll fix this.

@dotsdl
Copy link
Collaborator

dotsdl commented May 25, 2016

K...now with better accounting, coverage looks like about 30%. I think codecov doesn't pick up failed builds, either, so we have to get these passing before that is fixed, too.

@orbeckst
Copy link
Member Author

orbeckst commented Jun 9, 2016

I can close this issue when I get coverage on travis but for this to happen, all current tests must pass, i.e., #61 must be fixed.

@orbeckst orbeckst modified the milestones: 0.5 bugfixes, 0.6 Jun 9, 2016
@orbeckst orbeckst modified the milestones: 0.5 bugfixes, 0.6 Jul 4, 2016
@orbeckst
Copy link
Member Author

orbeckst commented Aug 3, 2016

@ianmkenney got Gromacs working with PR Becksteinlab/MDPOW#44 (see Becksteinlab/MDPOW#41).

@orbeckst
Copy link
Member Author

orbeckst commented Sep 9, 2016

Tests passing and coverage properly reported.

@orbeckst orbeckst closed this as completed Sep 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants