Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widgets should use custom language #5243

Open
Beep6581 opened this issue Mar 25, 2019 · 1 comment
Open

Widgets should use custom language #5243

Beep6581 opened this issue Mar 25, 2019 · 1 comment
Labels
scope: localization Translation type: bug Something is not doing what it's supposed to be doing

Comments

@Beep6581
Copy link
Owner

Widgets such as Gtk::ColorButton (Preferences > General > Appearance > Crop mask color) and Gtk::FontButton (Preferences > General > Appearance > Main font) currently always use the system language as set by the locale, even when RawTherapee is set to use a custom language. The reason for this, according to GTK+ devs, is that RawTherapee should read the language from the options file and perform setlocale() in main() before anything else (so restart required), and not use g_setenv() as it currently does.

Simple way to test:

  1. Set RawTherapee to use Deutsch or French.
  2. Run RawTherapee using Italian (assuming you have an Italian locale on your system):
LC_ALL="it_IT.utf8" ./rawtherapee

screenshot_20190325_014712

@Beep6581 Beep6581 added type: bug Something is not doing what it's supposed to be doing scope: localization Translation labels Mar 25, 2019
@Beep6581 Beep6581 added this to the v5.7 milestone Mar 25, 2019
@Floessie
Copy link
Collaborator

@Beep6581 I remember we had problems with setlocale() in #4319...

@Beep6581 Beep6581 removed this from the v5.7 milestone Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: localization Translation type: bug Something is not doing what it's supposed to be doing
Projects
None yet
Development

No branches or pull requests

2 participants