Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roadmap for v5.9 #5632

Closed
Beep6581 opened this issue Feb 4, 2020 · 174 comments
Closed

Roadmap for v5.9 #5632

Beep6581 opened this issue Feb 4, 2020 · 174 comments
Labels
Milestone

Comments

@Beep6581
Copy link
Owner

Beep6581 commented Feb 4, 2020

https://github.com/Beep6581/RawTherapee/issues?utf8=%E2%9C%93&q=is%3Aissue+milestone%3Av5.9

@Beep6581 Beep6581 added this to the v5.9 milestone Feb 4, 2020
@Beep6581
Copy link
Owner Author

Hey

Let me know what is the status of the codebase in terms of stability, feature-completeness and stabilization of PP3 data, so that we can plan for the 5.9 release.

@Thanatomanic
Copy link
Contributor

Hi @Beep6581 welcome back online. No trouble with COVID-19 I hope?

There are quite some issues tagged v.5.9 for which nothing noteworthy has happened. What is your suggested timeframe?

@Floessie
Copy link
Collaborator

@Beep6581 @heckflosse @Hombre57 @Desmis @Thanatomanic I noticed that Ingo tagged some issue "6.0". Shouldn't the next version after 5.9 be "5.10"? Wouldn't "6.0" warrant incompatible changes (like PP4 or something)?

@TechXavAL
Copy link

There is a discussion about some changes in the future v6.0 that maybe would warrant a change in major version.

@heckflosse
Copy link
Collaborator

I tagged some issues 6.0 because that was the only tag available after 5.9

@TechXavAL
Copy link

Even if there is a 5.10 version, you may wish to discuss when those tools should be removed (on which version), so you can warn users within the application that they will be removed in the next release version: every time they use a deprecated tool, some sort of warn should be shown telling that tool will disappear in the next version.

If they should be removed in v.5.10 (or 6.0), then you should consider adding those warnings in v.5.9

@Beep6581
Copy link
Owner Author

Hi @Beep6581 welcome back online. No trouble with COVID-19 I hope?

There are quite some issues tagged v.5.9 for which nothing noteworthy has happened. What is your suggested timeframe?

Hey, no COVID-related issues here.

Shouldn't the next version after 5.9 be "5.10"? Wouldn't "6.0" warrant incompatible changes (like PP4 or something)?

Yes, 5.10 follows 5.9, though non-computer people find 5.10 confusing so it would be nice to break compatibility to warrant 6.0 :)

every time they use a deprecated tool, some sort of warn should be shown telling that tool will disappear in the next version.

No support for that idea from me, I consider that pointless and bloat. There are more urgent things that users should be notified about: #4261 #2899

@Beep6581
Copy link
Owner Author

Beep6581 commented Sep 2, 2020

Hey everyone

How are sentiments regarding feature-completeness and stability with regards to releasing 5.9? I see many commits involving wavelet-related stuff, @Desmis let us know when you feel it's feature-complete so we can feature-freeze and go into bugfixing and eventially get 5.9 out the door this year.

@Thanatomanic
Copy link
Contributor

I think we're pretty much feature complete. There are only two things I feel should definitely be included:

Other than that, the current two PRs on changes to the histogram would be nice-to-have, not need-to-have, imo.

@Beep6581
Copy link
Owner Author

"Waveform and vectorscopes" #5887 would be nice to have.

I still need a response from @Desmis regarding "Various improvment to Local adjustments" #5903

@Desmis
Copy link
Collaborator

Desmis commented Sep 20, 2020

@Beep6581

For "Various improvment to Local adjustments" #5903, the response is with Ingo... @heckflosse

Jacques

@heckflosse
Copy link
Collaborator

I think, we should delay #5903 for 6.0. Currently it needs too much memory, which will stress Jacques and me if we merge it now.
Better to take some time to improve it before we merge.
Jacques, I hope, you don't mind.

@Desmis
Copy link
Collaborator

Desmis commented Sep 20, 2020

@Beep6581 @heckflosse

No problem for 6.0

Jacques

@Beep6581
Copy link
Owner Author

Beep6581 commented Oct 1, 2020

Great, then I will gear up for releasing a 5.9-beta1 soon.

@Desmis
Copy link
Collaborator

Desmis commented Oct 1, 2020

@Beep6581
I think we need a few more days to work out with Wayne Sutton, the review (in good English) of all the labels and tooltips in Local adjustments...
But perhaps, it is not a problem, if some labels or tooltips wil be update after ?

Jacques

@Beep6581
Copy link
Owner Author

Beep6581 commented Oct 1, 2020

@Desmis there is no hurry. We need to review and complete the strings first, because if they get translated into e.g. 15 languages and then if changes are required then that's 15 times more work later on.

Could you point me to the branch/issue where you are reviewing the strings?

@Desmis
Copy link
Collaborator

Desmis commented Oct 1, 2020

@Beep6581

We work on this feature since beginning september 2020.

Similarly, rawpedia has been translated and improved by Wayne Sutton
https://rawpedia.rawtherapee.com/Local_controls

Now we are working on tooltips for "softlight & original retinex", "common mask" and "Dynamic range & exposure" in branch "local_tool". I think tomorrow (or perhaps latter) I will merge this branch

I think these tools are finished (labels, tooltips...and fixed bugs), but you can improve if you want

  • color and light
  • shadows highlight - tone equalizer
  • vibrance - warm cool
  • log encoding

Tomorrow or just after

  • Dynamic range & exposure
  • common color mask
  • soft light - original retinex

These tools represent about 80% of uses...
I think we need about 1 or 2 weeks (perhaps a little more) to finish

And a big thanks to Wayne Sutton for his patience, the relevance of his proposals, the dialogue between us, ....

Jacques

@rom9
Copy link
Collaborator

rom9 commented Oct 2, 2020

Hi all, sorry for the late comment.
Regarding the film negative tool, there's still a lot of brainstorming on Pixls, but if you think it's worth it, i could quickly finalize a version with a minimal set of features, which would bring:

  • non-raw file support (aka scanner TIFFs)
  • huge speedup for raw files (not having to re-demosaic each time)
  • backwards compatibility with PP3 created with previous versions.

...and postpone current experiments / feature request for the next release.

What do you think?

EDIT: just in case, the latest hacks have been rolled back, the branch should now be in a clean state ;-)

@Beep6581
Copy link
Owner Author

Hey

In order to get 5.9 out the door, I want to remove all issues from the 5.9 milestone, except for issues marked as documentation - these must be done before a release can be made. If there are any non-documentation issues you require for 5.9, speak now.

@Beep6581
Copy link
Owner Author

@Desmis what is your intention regarding your work and 5.9? i.e. is there a point of stability & feature completeness you're aiming for that 5.9 should wait for, or are we at that point now?

@Thanatomanic
Copy link
Contributor

@Beep6581 I am all up for making good work of getting 5.9 out! Could we take, let's say, 1-2 weeks to focus attention on these milestone issues? There are a few bugs that should probably get some attention. Jacques is less available this week anyway.

@Desmis
Copy link
Collaborator

Desmis commented Feb 24, 2021

@Beep6581
the only point to "wait"...is the PR for "grain"...
#6120
if no remark, objections....I will merge saturday or sunday

:)

jacques

@Beep6581
Copy link
Owner Author

@Thanatomanic could you list here the issues you want to keep, or assign them to yourself? Then I will omit them when removing the others.

@Desmis ok great.

@Thanatomanic
Copy link
Contributor

Thanatomanic commented Feb 24, 2021

@Beep6581 Below is my pick of the most important milestone issues. It would be ideal if people assigned to other milestone issues could indicate whether they want to take action, or increase or remove the milestone. But if you want to decide that to speed things up, feel free.

Important things:

Things I'll pick up myself:

@Thanatomanic Thanatomanic pinned this issue Apr 18, 2021
@Desmis
Copy link
Collaborator

Desmis commented Apr 19, 2021

@Beep6581 @Thanatomanic @heckflosse @rom9 @Floessie @Pandagrapher @Lawrence37 @TechXavAL @waynesutton50

And others....

Excuse my bad english

What are we waiting ?

I see the comments on the French forums "Rawtherapee is dead"...or the remarks on Pixls.us more and more insistent..."what happens"...The answers given are ambiguous and not very credible....There is a perception (at least for me) of conflict or disagreement within the team

if we make a comparison with DT on the one hand we have a new version practically every 2 months, and for us that will make 15 months !! (while the number of commits is very high)

Admittedly I have withdrawn from the project - partly because of this - but this is not a reason to do nothing.

For me the 2 PR "spot removal" and "trcnew" must be merge.... unless major opposition (these 2 PR are open for several months)

Do we not agree on the aims of RT? If for some of us is that Rawtherappe must be a simpler software..I think it is missed...The place has been taken with brilliance by ART. I think, maybe I'm the only one? that the positioning of RT, now that there is ART is the excellence in areas little explored by other software on the market (such as Wavelet, Ciecam ...)

Jacques

@Thanatomanic
Copy link
Contributor

@Desmis

First of all, I'm going to make a blunt statement, then a more nuanced one. Please bear with me.

Jacques, you have currently withdrawn from the project because you don't like how things are going, because the team seems undecisive, or unresponsive or simply because there is criticism on your proposed feature(s). The way I see it, this leaves you with three options: 1) take charge of the project and lead us forward, 2) leave, fork the project like Alberto and do whatever you want on your own terms, or 3) keep discussing and working together on the nuanced points I make below.

My observations on the project are as follows, as I have said in similar terms on Pixls a few times:

  1. There is no clear, broadly agreed vision for RawTherapee (if there ever was any...) Everybody has a personal vision, of course, but these can differ a lot, which inevitably leads to disagreements. A lack of future vision also slowly kills the project if we cannot fill our niche anymore and we lose users (not that we really care, but the competition with darktable for the raw processing niche is strong).
  2. There is no clear project manager. At least, not anymore since the beginning of 2020 when the contributions of @Beep6581 strongly diminished (no judgement, just stating facts). I have tried my best to keep the GitHub maintained and jump in for support on Pixls, and although I am willing, I am not able to take on more responsibilities due to time constraints. Besides, I have no idea how to prepare and deploy a release...
  3. There is a very small development team. The vast majority of coding is done by Ingo and you (Jacques) and there is definitely still wonderful progress. But there is more to the project than being a "feature factory", and imo there is hardly any time for quality control, bug fixes, usability improvements, etc. Documentation is also an issue for which Xavier contributes a lot.
  4. People's available time is limited. This just extends the previous point. Additionally, it can lead to a lot of frustration whenever somebody has much more time (like you, Jacques) than somebody else (like me). You may be thinking "Why is nobody commenting? Does nobody care?" which can lead to "I'll just merge it myself then...". While on the other side you have me thinking "I want to properly comment, because I care, but I don't have time" and then I may forget and after a merge I'm like "Oh, now it's done and there's no going back." and even a little bit of "This is turning into a one-man's project, I don't like that...".

I truly wish we could change this and improve how we function as a team and how we continue to push RawTherapee to become a better program. But right now, I completely understand the sentiment that RawTherapee seems dead when we haven't had a release for more than a year, nor any sort of public update on what is going on behind the scenes. I know we are still enthusiastic for our project, but I am also afraid we are very close to coming to a complete standstill.

I have no solid suggestion on how to change any of this in a significant way, except one which would cost me a lot of time. A simple idea is to try and schedule a Zoom call or something. That way at least we could do a lot of good in terms of getting to know each other and each others motivations. If anybody has other opinions, please share.

@Desmis
Copy link
Collaborator

Desmis commented Apr 19, 2021

@Thanatomanic
Why target a personalized response when my point is general?
For points 1) and 2) there is no question of it, given my age (74) and my poor health.

You are forgetting a 4th possibility...that I leave this project permanently.

That leaves 3) which seems to me a way forward.

As for "zoom" or any other live exchange, I will find myself totally isolated given my very poor performance in the language of Shakespeare

Jacques

@AndyAstbury
Copy link

Switching to LibRaw would be absolutely the very best move, no doubt about it.

@Beep6581
Copy link
Owner Author

Generating macOS universal this afternoon. Link to follow.

@Benitoite any luck?

@Benitoite
Copy link
Contributor

Yes, I have generated this Universal build:
https://kd6kxr.keybase.pub/RawTherapee_macOS_11.0_Universal_5.9-rc1.zip

@Beep6581
Copy link
Owner Author

Note to self:
include macOS hints in website announcement.
http://rawpedia.rawtherapee.com/MacOS#macOS_installation

@Beep6581
Copy link
Owner Author

@Benitoite so the oldest supported macOS for 5.9 is macOS Big Sur (version 11), is that correct?

@Manfred-Knick
Copy link

If more people are expected to test 5.9-RC1, wouldn't it make sense to increase visibility
by (temporarily) publishing it to http://rawtherapee.com/downloads/ ?
Moreover, at the same time, this intermediate would give a strong hint "we are moving forward, indeed".

@Beep6581
Copy link
Owner Author

Beep6581 commented Nov 27, 2022

@Benitoite so the oldest supported macOS for 5.9 is macOS Big Sur (version 11), is that correct?

@Benitoite according to macosx_bundle.sh the MINIMUM_SYSTEM_VERSION is 10.15 (Catalina), so please help me understand what's going on. Seems to me that the current macOS workflow is not to be used.

I have generated this Universal build:

What is a universal build?

We need a macOS build for the 5.9 release.

@Beep6581
Copy link
Owner Author

5.9 is going live on the website tomorrow, would be nice if there was a macOS build to go with it.

@Entropy512
Copy link
Contributor

What is a universal build?

I believe that means x86-64 + arm64 in a single binary.

@Beep6581
Copy link
Owner Author

RawTherapee 5.9 has been released and is live.

@Beep6581
Copy link
Owner Author

Ping me when a macOS build is available.

@Lawrence37 Lawrence37 unpinned this issue Nov 30, 2022
@Floessie
Copy link
Collaborator

Pinging @innir for Debian integration. 😊

@Jacalz
Copy link

Jacalz commented Nov 30, 2022

Fedora also hasn't been updated. If anyone knows the people there it would be good to get that fixed as well :)

@Floessie
Copy link
Collaborator

@Jacalz Mattia Verga is already participant in this issue.

@mattiaverga
Copy link
Contributor

I'll update Fedora RPMs in the next few days

@innir
Copy link
Contributor

innir commented Nov 30, 2022

I just uploaded 5.9 to Debian ... so curious to see all the great improvements and new features :-) Thanks for all your work!

@Floessie
Copy link
Collaborator

Floessie commented Dec 1, 2022

@mattiaverga @innir Mattia and Philip: Thank you for your continued support! 👍

@Beep6581
Copy link
Owner Author

@Benitoite any chance of getting a macOS build of 5.9?

@Lawrence37
Copy link
Collaborator

@Beep6581 In case you missed it, @Benitoite as a macOS build for 5.9: #6660 (comment)

@Benitoite
Copy link
Contributor

Here is a new 5.9 release build with updated libs targeting 11.7 on both intel and arm systems.
https://kd6kxr.keybase.pub/RawTherapee_macOS_11.7_Universal_5.9.zip

@Beep6581
Copy link
Owner Author

Beep6581 commented Feb 27, 2023

@Benitoite are you still happy with that being uploaded as the official 5.9 macOS build?

@Benitoite
Copy link
Contributor

@Beep6581 Yes, it is suitable.

@Beep6581
Copy link
Owner Author

Beep6581 commented Mar 2, 2023

@Benitoite keybase has shut down. Could you send the file some other way?

@Benitoite
Copy link
Contributor

@Beep6581 Indeed today I noticed someone named Zoom has just caused keybase.pub to go permanently down, although the kbfs still works fine. This has caused me to cease doing business with Zoom (*except where mandated or requested by legal or professional obligation) anymore as of today, and will be moving forthwith to GitHub.

https://github.com/Benitoite/rt59/raw/main/RawTherapee_macOS_11.7_Universal_5.9.zip

@Beep6581
Copy link
Owner Author

Beep6581 commented Mar 3, 2023

@Benitoite the macOS build is live. Are the macOS Installation Instructions on our Download page still accurate?

@Benitoite
Copy link
Contributor

@Beep6581 I would add this for the new build: Processing threads in the performance tab = 0 by default causes many crashes on arm64. Set it to 2 if this persists.

@Lawrence37
Copy link
Collaborator

@Beep6581 @Benitoite The download page shows

There is a known issue concerning macOS Ventura (version 13) wherein it may be impossible to click on some GUI elements, specifically drop-down menus.

Is it true for @Benitoite's build?

@Benitoite
Copy link
Contributor

Not to my knowledge as that issue still only pertains to an outdated version of gtk+-3.24.x.
#6660 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests