Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strength Control on Local Adjustment Spots RTDev #6221

Closed
AndyAstbury opened this issue May 1, 2021 · 6 comments
Closed

Strength Control on Local Adjustment Spots RTDev #6221

AndyAstbury opened this issue May 1, 2021 · 6 comments

Comments

@AndyAstbury
Copy link

The main Wavelets panel has a strength control at the top of it, so you can 'turn down' the 'volume' of your carefully crafted adjustments and slider ratios etc. It gives you that final tweak of finesse.
So I was wondering if that would be possible on Local Adjustment Spots as it would just add the same finesse without having to go back down the panel and adjust multiple controls.

@waynesutton50
Copy link

Having seen how useful it is in Wavelets, I think this would be a big plus for Local Adjustments

@TechXavAL
Copy link

If this is ever implemented, could it be added to each spot, instead of to the whole tool?

That way you will have complete control over each spot.

@Desmis
Copy link
Collaborator

Desmis commented May 2, 2021

A "strength" slider only makes sense if it is specific to each Spot and each tool

I have chosen a number of tools that I believe are more than sufficient to meet Andy's needs

  • local contrast & wavelet (new)
  • log encoding (already operational)
  • denoise (new)
  • color and light (new)
  • Dynamic Range and exposure (new)
  • SH and Tone equalizer (new)
  • retinex (already operational)
  • tone mapping (new)

Some have caused me a lot of trouble (denoise, Tone mapping)

This modification required a lot of code, but this is not a problem if it answers a request

You can find the changes in the branch - "lastrength"

I will create a PR this afternoon

Jacques

@AndyAstbury
Copy link
Author

Yes, please merge into current dev build, and many thanks to Jacques for implementing this in such a short time - brilliant!

@waynesutton50
Copy link

I've just tried the latest commit and haven't found any obvious problems. Thanks to Andy for the idea and to Jacques for the implementation.

@Desmis
Copy link
Collaborator

Desmis commented May 4, 2021

@AndyAstbury @waynesutton50 @TechXavAL

Merge

Jacques

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants