-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Posterization / Precision Loss with Working Profile Custom Tone Response Curve #6378
Comments
Thanks for reporting, but this tool was completely revamped last year. Can you test the development branch to see if you can reproduce it there? |
I can reproduce this in 5.8 but not with a recent |
AFAIK you don't need to tweak the Working Profile TRC at all:
Don't trust what you see on-screen, as this is the linear TRC image that comes from the engine, but converted to whatever color space and TRC your display uses. |
@Thanatomanic I did attempt to test this compiling directly from the code in the latest commit of the github repo, but trying to open that compilation here on Linux Centos 8 segfaults on start... Do you have any pointers on if there is a specific branch or tag that would be a more stable place to compile from, but with the improvements you speak of? Thanks very much for the info and links @TechXavAL. Today I learned about the ICC Profile Creator and how to customize the ICC Color Profiles Directory. You are indeed correct that if you customize the icc profiles and create an output profile that has a linear gamma it works. It's too bad that there is not an included output profile that is just a bypass so that it outputs the working profile. Here's what I did, in case there are other readers with the same problem.
Thanks again for the help. |
The last commit is supposed to be stable. You can try the AppImage from the automated builds. It's a bit old, but I think it has the new version (called "Abstract Profile"). There's a newer experimental AppImage here. The crash on startup is concerning. If you have the time, please consider reporting the issue along with a backtrace by following the instructions from RawPedia. |
We also have a detailed RawPedia page called "How to Fix Crashes on Startup"... |
Thanks! I learned some things about how the config and cache directories are set up reading through this page. Unfortunately none of the things mentioned there fixed the crash on start. @Lawrence37 Thank you for the info! I tried the appimage from the automated builds and it works fine here and the segfault on startup issue is not present. I did some more digging, compiled with debug, and did a gdb stacktrace (for the first time) following the instructions here.
I don't know much about gdb or debugging or doing stack traces, but it looks like there is an issue with the version of lensfun I am linking against. I compiled lensfun 0.3.95 alpha from the master branch of their github page. Maybe their latest is incompatible and I need to compile an older version or the last stable release (0.3.2 ?). |
Yes, this could certainly explain it. |
Hey experts, I'm back again. I realized after more testing that my custom icc profile workaround above has a fatal flaw: it does not work on the commandline. If I use a pp3 file pointing to a custom ICC profile name, rawtherapee-cli does not use it. I have tried multiple icc profile locations including
Is there any workaround to get this working? Thanks for your help! EDIT: I figured this out with a fresh brain! I realized I had put the icc profile in |
I have searched through the open issues and don't see this mentioned so I am making a new issue to report this.
I am working on a python wrapper for converting camera raw images to scene-referred exr. One of the debayer engines supported is RawTherapee.
In order to use RawTherapee for demoisaic, I need to output linear gamma. The only way I have found to do this is to set Tone response curve: Custom and set Gamma and Slope to 1.0.
![screenshot_2021-11-06_20-36-55](https://user-images.githubusercontent.com/3261432/140627974-65d07046-65a6-47ed-916d-ee06eecaf761.png)
Unfortunately it seems that as soon as I switch Tone response curve from None to Custom, there is a huge loss of precision occurring in the image processing.
Here are a couple of example screenshots:
First, with Tone Response Curve set to None:
![screenshot_2021-11-06_20-28-31](https://user-images.githubusercontent.com/3261432/140628001-833a7cae-5173-49f0-9d0a-1cfdf9770479.png)
And here with Tone Response Curve set to Custom:
![screenshot_2021-11-06_20-28-39](https://user-images.githubusercontent.com/3261432/140628004-1db3ef8c-0733-43d2-a761-e3476d829edd.png)
The profile is exposing up the image so that you can see the posterization in the shadows more easily.
I was thinking of working around this issue by trying to find the equation used for Gamma and Slope... Maybe I could make a lut for the default 2.4 gamma 12.92 slope when Tone Response Curve = None... But I have not been able to locate where this is in the source code. And it seems like a pretty big workaround to an issue that should not be an issue in the first place.
Here is the raw image and the pp3 file used in the screenshot above, attached as a zip file. To reproduce:
M01-1141.zip
The text was updated successfully, but these errors were encountered: