feat(ui-select): support optional preview of items #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
willothy
force-pushed
the
ui-select-preview
branch
from
0abd1fa
to
90dd6f2
Compare
|
@Bekaboo I rebased this on top of master so it no longer depends on the closed PR - thoughts? I use this in my config for previewing code actions: |
|
Thanks, looks great! I are going to merge this after dealing with #131 |
Awesome, sounds good! |
willothy
force-pushed
the
ui-select-preview
branch
from
90dd6f2
to
c56b54f
Compare
|
@Bekaboo ready to merge this one soon? It's pretty minimal |
|
Yep, sorry for the delay. |
|
@willothy vimdoc missing |
|
Oops, my bad! I keep forgetting to mirror the readme changes to the vimdoc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds optional preview support to the ui-select menu, via the
previewandpreview_closefields on the options table.