feat: support preview for entries in path source menus

[willothy]

Adds support for previewing files from the path source.

[willothy]

Considering an alternate approach here... what if the previews for files worked the same way as for TS/LSP sources, where the file is previewed in the active window instead of a popup? I think that would allow the preview to be more consistently visible, since having nested menus open significantly shrinks the space available for the preview popup.

Could also make this configurable, so files could be previewed in a popup or the active window. This could also be extended to allow other kinds of symbols to be previewed in popups.

[willothy]

Not quite ready for merge but ready to be tested - now supports previewing in a floating window, or in the current window like document symbols are previewed.

[willothy]

Ok fixed the bugs, this should be pretty much ready as well.

[willothy]

I just need to document dropbar_menu_t:root_win()

I added it as a method instead of just doing a check in the path source because I think is useful to have and makes it more clear that prev_win can be either a menu or a regular buffer.

[willothy]

@Bekaboo this has been working well in my config for a bit, I'll upload a new video here today.

Do we want to have the floating preview though? It's different from how all of the other previews work and I'm not sure I'm a fan of it - I kinda want to remove it and have this PR only support preview in the way we already do in order to keep things consistent between the sources. Thoughts?

[Bekaboo]

@willothy Thanks for your work!

Do we want to have the floating preview though? It's different from how all of the other previews work and I'm not sure I'm a fan of it - I kinda want to remove it and have this PR only support preview in the way we already do in order to keep things consistent between the sources. Thoughts?

I agree with you.

[willothy]

Cool, sounds good! I'll clean this up and remove the floating preview.

[Bekaboo]

@willothy Is this ready to merge?

[willothy]

Uhh I forget, I'll look over it today and let you know. I think I just need to do a little bit of cleanup.

[willothy]

@Bekaboo ok, good to go! Sorry for the delay.

[Bekaboo]

Ty, looks great! @willothy I have been a bit busy recently but I'll review and merge this ASAP.

[willothy]

Sounds good! No rush :)

[Bekaboo]

@willothy Why do we need a new field preview_win? Before this patch, we always preview symbols in the current window (the window that the dropbar is attached to) and the window id is stored in dropbar_symbol_t.win, i.e. it is the symbol instead of the menu that is responsible for previewing.

[willothy]

Right, good catch! That's leftover from the popup preview, I should've removed it. I'll get rid of that now :)

[willothy]

@Bekaboo I've rebased onto master and removed the preview_win field. Should be all good now.

[Bekaboo]

@willothy Merged, thank you for your contribution!