New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix issue #4 by display a white background #5
Conversation
Thanks @yurimalheiros, looks great. Minor styling feedback. |
{text} | ||
</text> | ||
width="{size}px" height="{size}px"> | ||
<g> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unpad everything from this line and below 2 spaces.
I tried to fix the style, if it still no 100% ok, please let me know. |
<text y="50%" x="50%" fill="{color}" | ||
text-anchor="middle" dominant-baseline="central" | ||
style="font-family: {font_family}; | ||
font-size: {font_size}px"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move font-size
to the line above:
style="font-family: {font_family}; font-size: {font_size}px"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure
fix issue #4 by display a white background
Thanks! |
Hello, I added a rect shape to the svg for display only the rectangle in the correct size.