Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keypad overlays hold (pause) button #823

Closed
532910 opened this issue Nov 9, 2019 · 7 comments
Closed

keypad overlays hold (pause) button #823

532910 opened this issue Nov 9, 2019 · 7 comments

Comments

@532910
Copy link

532910 commented Nov 9, 2019

The pause (hold) button looks ugly, when keypad is opened:
image

@Viish
Copy link
Member

Viish commented Nov 12, 2019

Indeed this isn't very nice, but that depends on the screen resolution.
On all our devices here we don't have it...
What do you suggest ?

@532910
Copy link
Author

532910 commented Nov 12, 2019

Expand it to full width, same as the native dialer does:

image

@Viish
Copy link
Member

Viish commented Nov 15, 2019

Done in 5b5a08e

@Viish Viish closed this as completed Nov 15, 2019
@532910
Copy link
Author

532910 commented Nov 18, 2019

Looks better now, and "technically" the issue is fixed, but under "expand it to full width" I meant something like:
image
instead of
image

@532910
Copy link
Author

532910 commented Nov 18, 2019

Moreover, the pause button looks odd (as it is round comparing to other buttons). Possible it will be better to move it somewhere on the bottom panel and do not overlap with keyboard at all.

@Viish
Copy link
Member

Viish commented Nov 18, 2019

I hear you but I'm not in charge of the design.
Also note the record call and toggle camera buttons are also round like that.

@Viish
Copy link
Member

Viish commented Nov 18, 2019

And regarding the dialer I did it like that so it is the same as iOS version (and your solution is quite hard to implement considering the current layout file)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants