Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code in Draw component #21

Closed
BenJeau opened this issue Dec 24, 2020 · 2 comments · Fixed by #44
Closed

Refactor code in Draw component #21

BenJeau opened this issue Dec 24, 2020 · 2 comments · Fixed by #44

Comments

@BenJeau
Copy link
Owner

BenJeau commented Dec 24, 2020

Create a separation in the Draw component where users can

  • Create a canvas component that has no color picker / brush properties
@BenJeau BenJeau added enhancement New feature or request priority: med labels Dec 24, 2020
@BenJeau BenJeau added this to the v1.0 milestone Dec 24, 2020
@bottle-rocket-11
Copy link

This would be amazing!

@BenJeau
Copy link
Owner Author

BenJeau commented Feb 2, 2022

Just laying out the details:

  • @benjeau/react-native-draw would only contain the renderer/canvas
  • @benjeau/react-native-draw-extras would contain everything else (bottom section - color picker, brush properties, undo, delete)

Both of these dependencies will be in this repo - although I am unsure how to push to two separate npm packages with react-native-bob. I'm not sure when I'll do this, but I really want this do this since I already have the Skia renderer done and want to merge it with this code so bad, but I can't as of now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants