Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wait to display "setup complete" until they've read the two dialogs about the initial block download #34

Closed
BenWestgate opened this issue Jul 23, 2023 · 3 comments
Closed

wait to display "setup complete" until they've read the two dialogs about the initial block download #34

BenWestgate opened this issue Jul 23, 2023 · 3 comments
Labels
bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers priority: medium Issues raised by 1 tester

Comments

@BenWestgate
Copy link
Owner

BenWestgate commented Jul 23, 2023 •
edited
Loading

This issue was reproduced by @epiccurious so the priority was updated to medium.
@BenWestgate BenWestgate added bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers priority: medium Issues raised by 1 tester labels Jul 23, 2023
@BenWestgate
Copy link
Owner Author

I replied:

Ok two issues in one there.
First wallet setup complete, must wait for the user to finish the encryption dialog

and then the IBD dialogs must wait for user to close wallet setup complete

and finally there's a bug where bails-wallet runs itself again sometimes when it's closed. So that's why you see a Create wallet window

@BenWestgate BenWestgate mentioned this issue Jul 27, 2023
Closed
2 tasks
@BenWestgate
Copy link
Owner Author

I believe I've implemented a fix but it has not been tested.

@BenWestgate
Copy link
Owner Author

removed the dialog altogether. Now there's a "wallet setup complete" which was the old "setup complete" and it displays after wallet encryption info and then two dialogs about Tails and bitcoin core run if it's never been installed before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers priority: medium Issues raised by 1 tester
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BenWestgate