New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vector_pixman_pixman-arm-neon-asm.S is included on all platforms resulting in an executable stack outside ARM #1
Comments
This file seems to be generated from the original rlottie repo. Let me see if latest rlottie has this issue... |
It think it had the same issue but it was fixed in Samsung/rlottie@7bcbea3. |
actually why non arm should include those line in the first place? no asm code is used for non arm. Or do you think somewhere in the cpp file has bad code? Sorry this project is mainly a wrapper of rlottie... |
It's currently equivalent to an empty file outside ARM. The problem is that an empty assembly file has no The pax-utils package on Linux has a scanelf utility that you can use to confirm in an executable including this library:
It will show |
Ok will fix in few days |
The snippet of code in this file disabling executable stacks isn't included on non-ARM architectures and results in the stack being made executable for the entire executable where this library is included:
A trivial fix for this is moving this block of code outside of the architecture ifdef wrapped around the file.
I noticed that matterbridge had an executable stack and quickly narrowed it down to this library. The executable stack makes memory corruption bugs much more easily exploitable and deters further hardening.
The text was updated successfully, but these errors were encountered: