Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bricked device after incorrect flash sequence #16

Closed
drgolem opened this issue Jun 17, 2011 · 1 comment
Closed

bricked device after incorrect flash sequence #16

drgolem opened this issue Jun 17, 2011 · 1 comment

Comments

@drgolem
Copy link

drgolem commented Jun 17, 2011

Hi Benjamin,
thank you for your great tool. It worked great for me until yesterday when I tried to flash Android 2.3.3 to my Galaxy Tab
Heimdall flashed pit, initial bootloader and than failed on flashing HIDDEN partition. After this my device was restarted and never turns up now. Screen just black and no signs of life :(
I'm still looking solutions how to revive it. But I don't blame you in any way. I think your tool could be improved if it would flash essential parts first instead of current way flashing in random order. I prepared a patch for you to have a look at changes and decide if they are good. Also I changed the way memory allocated, lot of places use 'new' and you have to remember delete objects afterwards.

Please, see how I changed mapFilesToPartitions function to create map of partitions. Now boot, sbl, kernel will be flashed first.
I verified code compilation on windows and linux.

Regards,
Val

see my changes at
git://github.com/DrGolem/Heimdall.git

@Benjamin-Dobell
Copy link
Owner

This issue has been responded to in detail via e-mail.

For anyone else who may be interested. I've decided not to adopt Val's changes for a few reasons. The most important from the end user's point of view is that it would introduce a fairly significant bug that breaks functionality for "unknown partition indexes". However, the order in which files/partitions are flashed will be altered so the bootloaders and param.lfs are always flashed last in the 1.2.1 update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants