Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing Gallery #27

Closed
nevakee716 opened this issue Mar 10, 2017 · 7 comments
Closed

Changing Gallery #27

nevakee716 opened this issue Mar 10, 2017 · 7 comments
Labels

Comments

@nevakee716
Copy link

Hello

If I change the galleryName parameter of the component, it doesn't work correctly

@BenjaminBrandmeier
Copy link
Owner

Please be more specific.
Did you ran the pre-processing script with the corresponding gallery name before?

@stefan-frank
Copy link

I have got the same issue, I presume.

I have run the pre-processing script with a galleryName (--gName=myGallery). If I then use

<gallery [galleryName]="myGallery"

I receive an error in the console, that it can not access the resources - instead of "myGallery" the path is substituted with "undefined":
http://localhost:4200/assets/img/gallery/undefined/preview_xxs/IMG_0306.JPG

I have been looking at the gallery-component, and it looks fine to me. Repeating the pre-processing without a gallery name is working fine.

@stefan-frank
Copy link

The solution is outlined in #25. This issue might be closed @nevakee716 ?

@nevakee716
Copy link
Author

It's not the same, after the component start, I want to change and display another gallery, so I change the galleryName but it's not working

@BenjaminBrandmeier
Copy link
Owner

Alright, understood.

@victooor Do you have time to look into this and provide another PR? Otherwise I will try to get some free time somewhen to fix this.

@victooor
Copy link
Contributor

@BenjaminBrandmeier sure, I will look into this

@BenjaminBrandmeier
Copy link
Owner

BenjaminBrandmeier commented Mar 25, 2017

I merged victooor's PR and published a new version. (0.6.1)
The PR should fix this issue, if not please comment here again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants