fix issue with en-IE currency #569
Conversation
|
@BenjaminVanRyseghem, just checking in on this PR and see if there is anything else needed on my end. Thanks. |
|
@BenjaminVanRyseghem checking in on this PR, is there any reason this can't be merged? Would like to be able to format currency for Ireland and in its current state I am not able using this library. This is fairly small update that should resolve the issue. Thanks. |
|
Sorry, I am very busy right now, I actually have an epic deadline next thursday... I'll have a look as soon as I have 5' 😄 Sorry for the inconvenience |
|
@BenjaminVanRyseghem, can this PR be merged? Thanks |
CHANGELOG.md
Outdated
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| ### 2.3.1 | |||
|
|
|||
| - Fix issue with en-IE currency by adding currency position of `prefix` | |||
There was a problem hiding this comment.
Sorry about that, pushed change to add PR #
| @@ -62,3 +62,4 @@ Thomas Obermüller (https://github.com/thomas88) | |||
| Tim Fish (http://github.com/timfish) | |||
| Tim McIntosh | |||
| Tim Schauder (https://github.com/cornflakeboy) | |||
| Wes Gabbard (https://github.com/Blackbaud-WesGabbard) | |||
There was a problem hiding this comment.
Move it to another commit please, so that possibly reverting your code won't remove you from the authors list 😄
|
do you have any documentation showing that the currency is prefix? (to avoid another PR tomorrow to change it as it happened already 😄) Sorry for the delay, and thanks for the PR |
|
Hey @BenjaminVanRyseghem, Few references: |
CHANGELOG.md
Outdated
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| ### 2.3.1 | |||
|
|
|||
| - Fix #569: Fix issue with en-IE currency | |||
There was a problem hiding this comment.
Still missing the Thanks to ... at the end 😄
|
Thanks for the correction. Could you please rebase your commits so that there are only 2:
thanks! |
|
One test failed: edit: the test is broken obviously, but that's for another PR 😄 |
|
My bad, long day. I should have at least made sure the unit tests passed locally before pushing up. |
|
you removed |
|
@Blackbaud-WesGabbard any chance you could re-visit this PR to make the changes requested? As an Irish dev I'm keen to see it merged 😄 |
|
@stephenmcbride @BenjaminVanRyseghem closing out and moving to #597 |
Ran into issue when trying to format currency for Ireland. When setting culture as en-IE was getting the following error:
Currency position should be among ["prefix", "infix", "postfix"]Looking at the en-IE.js file in the languages folder, it is missing a property defining the position of the currency symbol. Added this to be prefix since Euro symbols go in front. Updated the test to account for this.