Skip to content
This repository has been archived by the owner on Feb 19, 2023. It is now read-only.

PlayerFragment not responsive #45

Closed
Benji377 opened this issue Jun 9, 2021 · 6 comments · Fixed by #49
Closed

PlayerFragment not responsive #45

Benji377 opened this issue Jun 9, 2021 · 6 comments · Fixed by #49
Assignees
Labels
enhancement New feature or request

Comments

@Benji377
Copy link
Owner

Benji377 commented Jun 9, 2021

I noticed that on my friend's phone the Song time numbers weren't displayed correctly. They were squeezed into a tiny space to make room for the seek bar.
Right now the PlayerFragment is a Linearlayout, but maybe it would be better to have it in a ConstraintLayout for better responsiveness and supportiveness on more phones.

@Benji377 Benji377 added the enhancement New feature or request label Jun 9, 2021
@squivix
Copy link
Collaborator

squivix commented Jun 9, 2021

I noticed this on my phone too actually. Let me know if you can fix it.

@Benji377
Copy link
Owner Author

Benji377 commented Jun 9, 2021

Working on it

@Benji377 Benji377 self-assigned this Jun 9, 2021
@Benji377
Copy link
Owner Author

Benji377 commented Jun 9, 2021

This is my progress so far. I'm gonna test it now and hope it works. If yes I will create a pull request later

image

@Benji377
Copy link
Owner Author

Benji377 commented Jun 9, 2021

Well, it looks like it's working, but ist not being shown completely because of some weird navbar issue. @squivix I think this is something you might be able to fix. Creating a pull request now

@Benji377 Benji377 linked a pull request Jun 9, 2021 that will close this issue
@Benji377
Copy link
Owner Author

Benji377 commented Jun 9, 2021

The problem is that when you click on a song and the Fragment should appear, it actually only appears up to a certain point, which is kinda strange. It almost looks like the size of the fragment isn't big enough

@Benji377
Copy link
Owner Author

Benji377 commented Jun 9, 2021

Ok, I figured it out myself. I just had to tweak the Framelayout a little bit. Hope it works now responsive.

@Benji377 Benji377 linked a pull request Jun 9, 2021 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
2 participants