Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minified build #24

Open
alerque opened this issue Mar 5, 2014 · 2 comments
Open

Fix minified build #24

alerque opened this issue Mar 5, 2014 · 2 comments
Assignees
Labels

Comments

@alerque
Copy link
Collaborator

alerque commented Mar 5, 2014

The minified build currently breaks the auto-update system in several ways. First the build props need to support setting the auto-update URL to the version being used. Secondly a number of variables and functions need name protection across releases. Lastly it needs to stop stripping out "apparently unused" code bits. Just because a variable is assigned and not used in a function doesn't mean it isn't referenced externally.

@oliversalzburg
Copy link
Collaborator

Please check out #26 and tell me what else needs to be fixed.

What variable names need to be preserved?

@alerque
Copy link
Collaborator Author

alerque commented Mar 5, 2014

At there very least VERSION needs to be preserved, but I tried referencing it with window["VERSION"] and it still got munged. I think I already included a way for URL not to matter, but there was one other too. I'll post if I can remember what it was.

@oliversalzburg oliversalzburg removed this from the 1.3.4 milestone Mar 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants