Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong comment inserted while editing #53

Closed
oliversalzburg opened this issue Jun 12, 2014 · 6 comments
Closed

Wrong comment inserted while editing #53

oliversalzburg opened this issue Jun 12, 2014 · 6 comments
Assignees
Labels
Milestone

Comments

@oliversalzburg
Copy link
Collaborator

When editing a comment (by double-clicking it) while it is selected, pressing the Insert button will cause invalid data to be inserted into the target.

@Benjol
Copy link
Owner

Benjol commented Jun 13, 2014

Nice find 👍

@Benjol
Copy link
Owner

Benjol commented Jun 13, 2014

I guess a challenge is that a fix is going to have to work for both cases: normal insert and quick insert.
Thus it's probably better to merge in #52 and #54 first, then we/I can look at this one

@oliversalzburg
Copy link
Collaborator Author

@Benjol You're right. I already looked at a possible fix and that area of the code has a bit of overlap with especially the multi-target feature. So working on a fix for this issue would definitely result in a lot of pain when merging.

@Benjol
Copy link
Owner

Benjol commented Mar 12, 2015

@oliversalzburg, motivated? :)

@oliversalzburg oliversalzburg added this to the 1.4.1 milestone Mar 12, 2015
@oliversalzburg oliversalzburg self-assigned this Mar 12, 2015
@oliversalzburg
Copy link
Collaborator Author

I'll check it out again. But today I have to get some work done ;D

@Benjol
Copy link
Owner

Benjol commented Apr 15, 2015

I think we can call this fixed by #92

@Benjol Benjol closed this as completed Apr 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants