Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple conversions #53

Closed
VozikCZE opened this issue Jul 14, 2020 · 8 comments
Closed

Multiple conversions #53

VozikCZE opened this issue Jul 14, 2020 · 8 comments
Assignees
Labels
done task is complete enhancement New feature or request

Comments

@VozikCZE
Copy link

Description

Describe the bug

When you add add more than one conversion to one item, only the last conversion work.

Steps to reproduce the behavior

  1. Create greenhouse with more than one conversion and wait.

Expected behavior

All conversions should work.

Environment

Output of /bbox version (Mandatory)
[19:36:28 INFO]: Běžím na PAPER 1.16.1.
[19:36:28 INFO]: Verze BentoBox: 1.14.0
[19:36:28 INFO]: Databáze: JSON
[19:36:28 INFO]: Načtené herní světy:
[19:36:28 INFO]: bskyblock_world (BSkyBlock): Svět, Nether, End
[19:36:28 INFO]: Načtené doplňky:
[19:36:28 INFO]: BSkyBlock 1.13.1 (ENABLED)
[19:36:28 INFO]: Greenhouses 1.2.0-SNAPSHOT-b242 (ENABLED)
[19:36:28 INFO]: Level 2.3.0-SNAPSHOT-b391 (ENABLED)
[19:36:28 INFO]: Limits 1.14.0 (ENABLED)
[19:36:28 INFO]: Warps 1.9.7 (ENABLED)

(sorry for czech language)

Additional context (Optional)

Config of my greenhouse:

  CAVE:
    friendlyname: "&2Jeskyně"
    biome: PLAINS
    icon: STONE
    priority: 50
    contents:
      STONE: 6
    conversions:
      STONE: 10:COAL_ORE:STONE
      STONE: 10:IRON_ORE:STONE
      STONE: 3:GOLD_ORE:STONE
      STONE: 5:LAPIS_ORE:STONE
      STONE: 5:REDSTONE_ORE:STONE
      STONE: 1:DIAMOND_ORE:LAVA
      STONE: 1:EMERALD_ORE:LAVA
@tastybento tastybento added the enhancement New feature or request label Jul 15, 2020
@tastybento
Copy link
Member

Yes, right now, just one recipe is possible. I'll mark this as an enhancement to support multiple recipes.

@VozikCZE
Copy link
Author

This is very usefull function, will you add it soon please?

@tastybento
Copy link
Member

I'm sorry, I'm super busy with real-life stuff, so maybe not for a while.

@tastybento
Copy link
Member

This is done. To use, you'll need to use the new format for conversions, like shown here:

    # Conversion list
    # Format is:
    # Original Block:% chance:New Block:Adjacent Block
    # So, for below, dirt has a 30% chance of changing into SAND if it is next to SAND!
    # Multiple conversions can be listed
    conversion-list:
    - DIRT:30:SAND:SAND
    - DIRT:10:WATER:SAND
    - DIRT:30:SAND:SANDSTONE
    - DIRT:30:SAND:CLAY

@tastybento tastybento self-assigned this Aug 16, 2020
@tastybento tastybento added the done task is complete label Aug 16, 2020
@tastybento tastybento reopened this Aug 16, 2020
@VozikCZE
Copy link
Author

Still it takes only the last conversion in list

  CAVE:
    friendlyname: "&2Jeskyně"
    biome: PLAINS
    icon: STONE
    priority: 50
    contents:
      STONE: 6
    conversion-list:
    - STONE:10:COAL_ORE:STONE
    - STONE:10:IRON_ORE:STONE
    - STONE:3:GOLD_ORE:STONE
    - STONE:5:LAPIS_ORE:STONE
    - STONE:5:REDSTONE_ORE:STONE
    - STONE:1:DIAMOND_ORE:LAVA
    - STONE:1:EMERALD_ORE:LAVA

@tastybento
Copy link
Member

Got it, I see the issue.

@tastybento
Copy link
Member

https://ci.codemc.io/job/BentoBoxWorld/job/Greenhouses/245/ should have the fix. Please try and confirm.

@VozikCZE
Copy link
Author

Yes, it works now.

Thank you for your willingness <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done task is complete enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants