Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical conversions #59

Closed
VozikCZE opened this issue Aug 21, 2020 · 2 comments
Closed

Vertical conversions #59

VozikCZE opened this issue Aug 21, 2020 · 2 comments
Assignees
Labels
under investigation this is being investigated

Comments

@VozikCZE
Copy link

Description

Is your feature request related to a problem?

Conversions now works only horizontally, but it might be usefull if they can works vertically.

Additional context

image

@tastybento tastybento added the enhancement New feature or request label Aug 21, 2020
@tastybento tastybento self-assigned this Aug 22, 2020
@tastybento tastybento added the under investigation this is being investigated label Aug 22, 2020
@tastybento
Copy link
Member

I looked though the code and it is set up to look for vertical up and down blocks as well as N/S/E/W blocks. It should work.

@tastybento tastybento added invalid This doesn't seem right and removed enhancement New feature or request under investigation this is being investigated labels Aug 22, 2020
@tastybento
Copy link
Member

Let me clarify - only the top block will be checked (searching down from the ceiling until a block is found). Then it is checked up, down, N/S/E/W. So if there are blocks above or below it that could convert it, then it'll be converted. I think you're thinking that it should check all blocks in the greenhouse. Let me check that.

@tastybento tastybento added under investigation this is being investigated and removed invalid This doesn't seem right labels Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
under investigation this is being investigated
Projects
None yet
Development

No branches or pull requests

2 participants