Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile errors using FPC 3.3.1 / Lazarus #343

Open
donsiders opened this issue Feb 19, 2024 · 1 comment
Open

Compile errors using FPC 3.3.1 / Lazarus #343

donsiders opened this issue Feb 19, 2024 · 1 comment

Comments

@donsiders
Copy link

I found and fixed a couple of errors when using FPC 3.3.1.

diff --recursive -d -w -a -b ../../usr/downloads/lazarus/HtmlViewer/source/HTMLSubs.pas HtmlViewer/source/HTMLSubs.pas
5755c5755
<       else if Self is TTableBlock and not TTableBlock(Self).Table.HeadOrFoot then {ordinary tables}
---
>       else if (Self is TTableBlock) and (not TTableBlock(Self).Table.HeadOrFoot) then {ordinary tables}
diff --recursive -d -w -a -b ../../usr/downloads/lazarus/HtmlViewer/source/htmlview.pas HtmlViewer/source/htmlview.pas
4511c4511
<   else if Sender is TFontObj and not NoJump then
---
>   else if (Sender is TFontObj) and (not NoJump) then

I was hoping you apply and submit an update for OPM.

Thanks in advance.

Don

@manliomazzon
Copy link

Good catch Don. I think the brackets are not needed around e.g. (not jump), since "not" strictly applies only to the next symbol, with the highest level of operator precedence, but the other brackets ARE definitely needed!! Thanks and cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants