Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Expand async callback support to other event types #1007

Closed
krrishdholakia opened this issue Dec 5, 2023 · 3 comments
Closed

[Feature]: Expand async callback support to other event types #1007

krrishdholakia opened this issue Dec 5, 2023 · 3 comments
Assignees
@krrishdholakia
Labels
enhancement New feature or request

Comments

@krrishdholakia
Copy link
Contributor

krrishdholakia commented Dec 5, 2023 •
edited

The Feature

We've implemented async custom callbacks on just success events for async completion/embedding calls. e0ccb28

Expand this to also support the other event types (pre-input, post-input, on-failure) and sync completion/embedding calls.

Motivation, pitch

consistent ux

Twitter / LinkedIn details

No response
@krrishdholakia krrishdholakia added the enhancement New feature or request label Dec 5, 2023
@krrishdholakia
Copy link
Contributor Author

+1 user requested

@krrishdholakia krrishdholakia self-assigned this Dec 6, 2023
@krrishdholakia
Copy link
Contributor Author

test case: use it to log events from proxy to fluent-bit

@krrishdholakia
Copy link
Contributor Author

closing as this is now supported for failure + customhandler class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krrishdholakia krrishdholakia

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@krrishdholakia