Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Food Reviews #126

Merged
merged 46 commits into from Nov 29, 2021
Merged

Food Reviews #126

merged 46 commits into from Nov 29, 2021

Conversation

MimiOlayeye
Copy link
Contributor

Let me know if there is anything I should change or add.

NOTE: originally this was supposed to be app backend, but I needed to have access to the FoodItem object so I added it to DCT backend.

@MimiOlayeye MimiOlayeye self-assigned this Nov 8, 2021
@MimiOlayeye MimiOlayeye added the review ready This issue is ready for review! label Nov 8, 2021
@MimiOlayeye MimiOlayeye added this to the Sprint 7 milestone Nov 8, 2021
@MimiOlayeye MimiOlayeye linked an issue Nov 8, 2021 that may be closed by this pull request
5 tasks
@MimiOlayeye MimiOlayeye changed the title Reviews food Reviews Nov 8, 2021
@MimiOlayeye MimiOlayeye changed the title food Reviews Food Reviews Nov 8, 2021
@RafaelPiloto10
Copy link
Member

This sets up the infrastructure for food reviews but its missing the FastAPI code that allows it to become part of the backend. Also, we will need a DCT Database for this, you can copy and paste the database code in #125 for food reviews and change the table from user to food_reviews with a nested reviews collection (users collection in #125).

@brendacano
Copy link
Contributor

I was gonna make the same comment about the database. I feel like there's a few different ways to save the food reviews in the database. Do we want it attached to only the food item or do we want to attach the user so that they can edit it. From your code it seems like we want the user to edit it in the future so we would need a model that has maybe the id of the user so we can verify its the users review, and the food rating.

@RafaelPiloto10 RafaelPiloto10 reopened this Nov 8, 2021
@RafaelPiloto10 RafaelPiloto10 removed the review ready This issue is ready for review! label Nov 9, 2021
@MimiOlayeye MimiOlayeye added help wanted Extra attention is needed fix in progress labels Nov 14, 2021
@RafaelPiloto10
Copy link
Member

@MimiOlayeye, tests were failing on GitHub because it couldn't import dotenv. Make sure you are adding any new libraries to requirements.txt so that GitHub know's which libraries to install.

@RafaelPiloto10
Copy link
Member

Review #160 to get passing tests

@MimiOlayeye
Copy link
Contributor Author

@RafaelPiloto10 Merging is blocked because you requested changes. Please review the changes I made when you get the chance. (thanks again for helping with the .env file!!)

Cheese & Quackers Board automation moved this from Review in progress to Reviewer approved Nov 29, 2021
@brendacano
Copy link
Contributor

@MimiOlayeye Everyone approved! You can merge

@Foxworth22 Foxworth22 removed the review ready This issue is ready for review! label Nov 29, 2021
@MimiOlayeye MimiOlayeye merged commit 27476d5 into dev Nov 29, 2021
Cheese & Quackers Board automation moved this from Reviewer approved to Ready for Demo Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Cheese & Quackers Board
  
Ready for Demo
Development

Successfully merging this pull request may close these issues.

[5pts] DCT Backend: Reviews of Food
4 participants