New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Home Screen View #56
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please merge the previous one first. The two have too much stuff in common...
Yes, I should have made my description clearer - merge the parents first |
It looks like merging the previous PR does not affect this one. Interesting. |
I guess I will review it anyway. |
I need to merge the updates into my branch and then push again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On iPhone 13 it gives me a text-overflow warning. I think this is due to the name being too long, and there is no space (<0px) for the dot textbox.
This is not that important, as the app still works, but there are a few ways to get around that. One quick fix might be to make the text a bit smaller. You can also try setting the left textbox to a fixed maximum size, and wrap them in multiple lines if the name gets too long.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall you have done an awesome job. The code is nice and neat. The structure is clear. Tests are complete. Great.
I fixed this by adding an AutoSizeText package. I figured this was the most responsive approach given screen sizes. We provide a max font size, and the AutoSizeText will find the font size that best fits the constraints as you suggested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't look through the code yet but from the images please change the star at the bottom to fit the hearts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good!
@DDavid233, what was the latest commit you made? Let's try to not inter-mix between pull requests. If you'd like something changed, request changes that I can add or merge. As the owner of this pull request, I am responsible for the code I merge. I cannot be responsible for that if we are intermixing code we add. I don't see tests for the latest commit which appears to be the home screen but on |
@RafaelPiloto10 That is my mistake. I was trying to revert it. |
I meant to start a new branch but ended up pushing to your branch instead. Sorry about that. |
I was trying to push a hard reset, but apparently, I don't have permission to do that. I pushed a revert commit instead. Everything should be back to where it was before. |
@DDavid233, no worries! Thank you for fixing it :) |
Parent (merge these first): #55
Description:
Implements the main home page and adds some core functionality.
item.dart
- Implements the data structure for each food itemmenu_data.dart
- Implements the core functionality that will interface with our DCT backend (mocked for now)home_screen.dart
- Implements the home screen pageScreenshots
Home View
Selecting Grilled Chicken