Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu Conversation IO in MC 1.16 'stop: true' not working: the player gets stuck #1159

Closed
Wolf2323 opened this issue Jul 6, 2020 · 6 comments
Assignees
Labels
Bug A bug in the code or in a documentation. Cantdo This cannot be done. Confirmed Something is confimed.

Comments

@Wolf2323
Copy link
Member

Wolf2323 commented Jul 6, 2020

In Spigot 1.16 the conversation option 'stop: true' in menu conversation IO dose not work.
If the player sneaks, while he is in a conversation, he leaves the armor stand. After that, he is not able to talk to the NPC again or to leave the NPC, because he is still in the conversation. The only thing the player can do, is relogging.

So it's not really hard to reproduce, but you have to configure some things:

  1. Set default_conversation_IO: menu
  2. Create a conversation with an NPC.
  3. Set stop: 'true' in the conversation
  4. Start the conversation
  5. Sneak, to leave the armor stand

Now you cant walk away from the NPC, because you are still in the conversation, but you are also not able to talk to the NPC again.

I see two solutions:

  1. prevent sneaking
  2. resume when klick on the NPC

i figured out that line of code, where the sneak produces the issue:

@Wolf2323 Wolf2323 added Bug A bug in the code or in a documentation. Confirmed Something is confimed. labels Jul 6, 2020
@Wolf2323 Wolf2323 added this to TODO in BetonQuest 1.12.0 via automation Jul 6, 2020
@Wolf2323 Wolf2323 self-assigned this Jul 6, 2020
@Wolf2323 Wolf2323 moved this from TODO to In Progress in BetonQuest 1.12.0 Jul 7, 2020
@Wolf2323
Copy link
Member Author

Wolf2323 commented Jul 9, 2020

There is this issue in ProtocolLib, that causes this problem
dmulloy2/ProtocolLib#892

@Wolf2323 Wolf2323 moved this from In Progress to Wait for feedback/approvement/blocked in BetonQuest 1.12.0 Jul 9, 2020
@Wolf2323 Wolf2323 added the Cantdo This cannot be done. label Jul 9, 2020
@seyfahni
Copy link
Member

seyfahni commented Jul 9, 2020

Seems to be caused by dmulloy2/ProtocolLib#897.

@Wolf2323
Copy link
Member Author

Wolf2323 commented Aug 5, 2020

It turned out, that this is a client side issue

@Wolf2323 Wolf2323 moved this from Wait for feedback/approvement/blocked to Done in BetonQuest 1.12.0 Aug 5, 2020
@Wolf2323
Copy link
Member Author

@SaltyAimbOtter
Copy link
Member

Seems like the client bug was fixed in 20w03a: https://www.minecraft.net/en-us/article/minecraft-snapshot-21w03a

@seyfahni seyfahni changed the title Menu Conversation IO - MC 1.16 'stop: true' not working the player get stucked Menu Conversation IO in MC 1.16 'stop: true' not working: the player gets stuck Apr 24, 2021
@Wolf2323
Copy link
Member Author

This issue has been fixed in MC 1.17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in the code or in a documentation. Cantdo This cannot be done. Confirmed Something is confimed.
Projects
No open projects
Development

No branches or pull requests

3 participants