Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialyzer error #40

Open
bradleygolden opened this issue Sep 28, 2020 · 2 comments
Open

Dialyzer error #40

bradleygolden opened this issue Sep 28, 2020 · 2 comments

Comments

@bradleygolden
Copy link

After the latest version bump to 2.0.0, for some reason including Burnex.is_burner?/1 in my application results in the following dialyzer error:

The guard test:

/=(_ :: false, false)

can never succeed.

I'm fairly confident that it's the is_burner/1 function as the second I remove the error goes away. Any thoughts on what's causing this?

@Betree
Copy link
Owner

Betree commented Sep 29, 2020

Hi @bradleygolden, sorry about this issue. I indeed saw some warnings with Dialyzer after we turned providers into a MapSet that seemed related with https://elixirforum.com/t/dialyzer-complaint-about-mapset-member-not-getting-proper-type-as-argument-possible-specs-bug-in-mapset/20780/15.

I didn't have much time to investigate so I just added a @dialyzer ignore, but I didn't think it would impact dependant projects.

I can't look at that right now, but happy to merge any contribution to fix this. We can also remove Dialyzer from this project if it simplifies things - the value added for such a small library is arguably low.

@bradleygolden
Copy link
Author

I had some difficulty finding a good fix for this other than maybe doing something hacky. I think for now I'm just going to ignore the dialyzer error and call it a day.

Do you think it's possible dialyzer will still throw an error in dependent projects if you remove it from this project? This might be worth double checking just to be safe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants