Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Allow BD on popouts and overlay #464

Closed
jerkhouri opened this issue Oct 13, 2020 · 9 comments
Closed

[Feature] Allow BD on popouts and overlay #464

jerkhouri opened this issue Oct 13, 2020 · 9 comments

Comments

@jerkhouri
Copy link

Describe the Bug
I want to change the background of the pop out of to green for my stream.
But that only works on discord app, when I click on the pop out, it's seems that the betterdiscord doesn't modify the new windows named "Pop Out".

To Reproduce
Add this code into the custom CSS and normally in the web version of discord its working, but not in the discord desktop app.

.wrapper-2qzCYF.popout-1MBou-{
    background-color:green;
}

Expected Behavior
I want to edit the pop out like I do with the discord desktop app.

Screenshots
This is the web application with the CSS edits manually
Screenshot_3

This is the desktop app with the CSS edit in the CSS editor
Screenshot_4

Discord Version
Stable 68815 (fdca70b)
BBD 0.3.5
Host 0.0.308
Injector 0.6.2
Windows 10 64-Bit (10.0.18362)

Additional Context
It seems that the better discord don't work with pop out..

@jerkhouri jerkhouri added the bug label Oct 13, 2020
@NFLD99
Copy link

NFLD99 commented Oct 23, 2020

As far as I'm aware bbd doesn't inject to popouts or overlays, iirc it's due to how bd runs and having those inject it causes issues.

@jerkhouri
Copy link
Author

I really hope than can be fixed.. because I use it for my stream :(

@NFLD99
Copy link

NFLD99 commented Oct 30, 2020

I really hope than can be fixed.. because I use it for my stream :(

you can use whatever you streaming with to chroma key it out

@jerkhouri
Copy link
Author

I really hope than can be fixed.. because I use it for my stream :(

you can use whatever you streaming with to chroma key it out

You right, but with a black chroma key, all the shadows in the webcam will be transparent too..
If I use green background-color, the problem can be fixed.

@rauenzi
Copy link
Member

rauenzi commented Oct 30, 2020

This is not a bug because as @NFLD99 mentioned, BD intentionally does not inject into popouts or the overlay. I'll leave this open as a feature request.

@rauenzi rauenzi changed the title [Bug]CSS editor don't work on Pop Out [Feature] Allow BD on popouts and overlay Oct 30, 2020
@rauenzi rauenzi added enhancement and removed bug labels Oct 30, 2020
@jerkhouri
Copy link
Author

This is not a bug because as @NFLD99 mentioned, BD intentionally does not inject into popouts or the overlay. I'll leave this open as a feature request.

Ok thanks for your answer..

So now I can't change the style of the pop out discord ?

@rauenzi
Copy link
Member

rauenzi commented Apr 3, 2021

So now I can't change the style of the pop out discord ?

Correct, BD never allowed for this. I'm not sure if this is even something I will add because BD as a whole would not work in the overlay or popouts. I would essentially need to create a mini-mod that just loads a specific theme.

@rauenzi
Copy link
Member

rauenzi commented Mar 4, 2023

This is going to be closed as not-planned

@rauenzi rauenzi closed this as not planned Won't fix, can't repro, duplicate, stale Mar 4, 2023
@DrMcCoy
Copy link

DrMcCoy commented Aug 27, 2023

Yeah, I'm going to ask you to please reconsider this decision. This is something I've been looking for for ages, because I actually want to remove the borders/margins in the popout

I'm using Discord for my RPG games, with Foundry VTT as the virtual tabletop and Discord providing voice and video chat. I use the popout window to have both Foundry VTT and my players visible at the same time on the same monitor, but all the wasted black space on the Discord popout has been driving me crazy for the last years. :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants