Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump version, remove explicit test version #10

Merged
merged 2 commits into from Feb 23, 2022
Merged

Conversation

definitelyokay
Copy link
Collaborator

@definitelyokay definitelyokay commented Feb 22, 2022

Description

Bump version, fix dependency resolution

/domain @btrautmann @samandmoore
/platform @btrautmann @samandmoore

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@nanda-prbot
Copy link

@definitelyokay needs to request domain review.
@definitelyokay isn't a platform reviewer and needs to request platform review.

HOW TO: Request Reviewers

2 similar comments
@nanda-prbot
Copy link

@definitelyokay needs to request domain review.
@definitelyokay isn't a platform reviewer and needs to request platform review.

HOW TO: Request Reviewers

@nanda-prbot
Copy link

@definitelyokay needs to request domain review.
@definitelyokay isn't a platform reviewer and needs to request platform review.

HOW TO: Request Reviewers

@nanda-prbot
Copy link

Needs somebody from @btrautmann and @samandmoore to claim domain review
Needs somebody from @btrautmann and @samandmoore to claim platform review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

@definitelyokay
Copy link
Collaborator Author

bump

@nanda-prbot
Copy link

Needs somebody from @btrautmann and @samandmoore to claim domain review
Needs somebody from @btrautmann and @samandmoore to claim platform review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

2 similar comments
@nanda-prbot
Copy link

Needs somebody from @btrautmann and @samandmoore to claim domain review
Needs somebody from @btrautmann and @samandmoore to claim platform review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

@nanda-prbot
Copy link

Needs somebody from @btrautmann and @samandmoore to claim domain review
Needs somebody from @btrautmann and @samandmoore to claim platform review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

@github-actions
Copy link

LCOV of commit 9094df0 during alchemist #18

Summary coverage rate:
  lines......: 100.0% (425 of 425 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@nanda-prbot
Copy link

Needs somebody from @btrautmann and @samandmoore to claim domain review
Needs somebody from @btrautmann and @samandmoore to claim platform review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

8 similar comments
@nanda-prbot
Copy link

Needs somebody from @btrautmann and @samandmoore to claim domain review
Needs somebody from @btrautmann and @samandmoore to claim platform review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

@nanda-prbot
Copy link

Needs somebody from @btrautmann and @samandmoore to claim domain review
Needs somebody from @btrautmann and @samandmoore to claim platform review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

@nanda-prbot
Copy link

Needs somebody from @btrautmann and @samandmoore to claim domain review
Needs somebody from @btrautmann and @samandmoore to claim platform review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

@nanda-prbot
Copy link

Needs somebody from @btrautmann and @samandmoore to claim domain review
Needs somebody from @btrautmann and @samandmoore to claim platform review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

@nanda-prbot
Copy link

Needs somebody from @btrautmann and @samandmoore to claim domain review
Needs somebody from @btrautmann and @samandmoore to claim platform review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

@nanda-prbot
Copy link

Needs somebody from @btrautmann and @samandmoore to claim domain review
Needs somebody from @btrautmann and @samandmoore to claim platform review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

@nanda-prbot
Copy link

Needs somebody from @btrautmann and @samandmoore to claim domain review
Needs somebody from @btrautmann and @samandmoore to claim platform review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

@nanda-prbot
Copy link

Needs somebody from @btrautmann and @samandmoore to claim domain review
Needs somebody from @btrautmann and @samandmoore to claim platform review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

pubspec.yaml Outdated Show resolved Hide resolved
@nanda-prbot
Copy link

Needs somebody from @btrautmann and @samandmoore to claim domain review
Needs somebody from @btrautmann and @samandmoore to claim platform review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

1 similar comment
@nanda-prbot
Copy link

Needs somebody from @btrautmann and @samandmoore to claim domain review
Needs somebody from @btrautmann and @samandmoore to claim platform review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

Copy link
Collaborator

@jeroen-meijer jeroen-meijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice :shipit:

pubspec.yaml Outdated Show resolved Hide resolved
@nanda-prbot
Copy link

Needs somebody from @btrautmann and @samandmoore to claim domain review
Needs somebody from @btrautmann and @samandmoore to claim platform review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

2 similar comments
@nanda-prbot
Copy link

Needs somebody from @btrautmann and @samandmoore to claim domain review
Needs somebody from @btrautmann and @samandmoore to claim platform review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

@nanda-prbot
Copy link

Needs somebody from @btrautmann and @samandmoore to claim domain review
Needs somebody from @btrautmann and @samandmoore to claim platform review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

@nanda-prbot
Copy link

Needs somebody from @btrautmann and @samandmoore to claim domain review
Needs somebody from @btrautmann and @samandmoore to claim platform review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

2 similar comments
@nanda-prbot
Copy link

Needs somebody from @btrautmann and @samandmoore to claim domain review
Needs somebody from @btrautmann and @samandmoore to claim platform review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

@nanda-prbot
Copy link

Needs somebody from @btrautmann and @samandmoore to claim domain review
Needs somebody from @btrautmann and @samandmoore to claim platform review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

@github-actions
Copy link

LCOV of commit a094a09 during alchemist #19

Summary coverage rate:
  lines......: 100.0% (425 of 425 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@definitelyokay definitelyokay merged commit dd024d4 into main Feb 23, 2022
@definitelyokay definitelyokay deleted the versions branch February 23, 2022 13:40
@nanda-prbot
Copy link

@definitelyokay merged without required approvals.
(╯°□°)╯︵ ┻━┻ ʎɐʞoʎləʇᴉuᴉɟəp
cc: @Betterment/security

@nanda-prbot
Copy link

Needs somebody from @btrautmann and @samandmoore to claim domain review
Needs somebody from @btrautmann and @samandmoore to claim platform review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

2 similar comments
@nanda-prbot
Copy link

Needs somebody from @btrautmann and @samandmoore to claim domain review
Needs somebody from @btrautmann and @samandmoore to claim platform review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

@nanda-prbot
Copy link

Needs somebody from @btrautmann and @samandmoore to claim domain review
Needs somebody from @btrautmann and @samandmoore to claim platform review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

@samandmoore
Copy link
Member

<<domainlgtm platformlgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants