Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix link #12

Merged
merged 2 commits into from Feb 23, 2022
Merged

chore: Fix link #12

merged 2 commits into from Feb 23, 2022

Conversation

definitelyokay
Copy link
Collaborator

@definitelyokay definitelyokay commented Feb 23, 2022

Description

Should fix #11

/domain @btrautmann
/platform @btrautmann

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@nanda-prbot
Copy link

@definitelyokay needs to request domain review.
@definitelyokay isn't a platform reviewer and needs to request platform review.

HOW TO: Request Reviewers

3 similar comments
@nanda-prbot
Copy link

@definitelyokay needs to request domain review.
@definitelyokay isn't a platform reviewer and needs to request platform review.

HOW TO: Request Reviewers

@nanda-prbot
Copy link

@definitelyokay needs to request domain review.
@definitelyokay isn't a platform reviewer and needs to request platform review.

HOW TO: Request Reviewers

@nanda-prbot
Copy link

@definitelyokay needs to request domain review.
@definitelyokay isn't a platform reviewer and needs to request platform review.

HOW TO: Request Reviewers

@github-actions
Copy link

LCOV of commit e7adf60 during alchemist #20

Summary coverage rate:
  lines......: 100.0% (425 of 425 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@definitelyokay
Copy link
Collaborator Author

Hmm, maybe I should link the docs to the one on main since people will be finding this through the example there. Not sure if these relative links are fully working on pub.dev, given all the issues it has with that sort of thing.

@nanda-prbot
Copy link

@definitelyokay needs to request domain review.
@definitelyokay isn't a platform reviewer and needs to request platform review.

HOW TO: Request Reviewers

@github-actions
Copy link

LCOV of commit d1dd742 during alchemist #21

Summary coverage rate:
  lines......: 100.0% (425 of 425 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@nanda-prbot
Copy link

@definitelyokay needs to request domain review.
@definitelyokay isn't a platform reviewer and needs to request platform review.

HOW TO: Request Reviewers

@btrautmann
Copy link
Contributor

<< domain lgtm
<< platform lgtm

@nanda-prbot
Copy link

@definitelyokay needs to request domain review.
@definitelyokay isn't a platform reviewer and needs to request platform review.

HOW TO: Request Reviewers

@definitelyokay
Copy link
Collaborator Author

bump

@btrautmann
Copy link
Contributor

<< domain lgtm
<< platform lgtm

@Kirpal
Copy link
Collaborator

Kirpal commented Feb 23, 2022

nanda?

@btrautmann btrautmann merged commit 25a10ba into main Feb 23, 2022
@btrautmann btrautmann deleted the fix-link branch February 23, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: Dead link for recommended setup example
4 participants