Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Make README improvements #15

Merged
merged 4 commits into from Oct 26, 2021
Merged

docs: Make README improvements #15

merged 4 commits into from Oct 26, 2021

Conversation

CelticMajora
Copy link
Contributor

📰 Summary of changes

Adds more detail to README
Resolves #7

/domain @samandmoore @btrautmann
/no-platform

@CelticMajora CelticMajora self-assigned this Oct 22, 2021
@nanda-prbot
Copy link

Needs somebody from @samandmoore and @btrautmann to claim domain review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

1 similar comment
@nanda-prbot
Copy link

Needs somebody from @samandmoore and @btrautmann to claim domain review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

Copy link
Member

@samandmoore samandmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<<domainlgtm

Some small comments

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link

@nanda-prbot nanda-prbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! 🙌 👻 🤘

Copy link

@nanda-prbot nanda-prbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! 🥑 🤘 🌯

Copy link

@nanda-prbot nanda-prbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! 🌟 ⭐ 💰

nanda-prbot
nanda-prbot previously approved these changes Oct 26, 2021
Copy link

@nanda-prbot nanda-prbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! 🍟 🌞 ⭐

@nanda-prbot
Copy link

This PR requires additional review because of new changes

Please get another domain review from @samandmoore, or another reviewer with write access if unavailable.

@nanda-prbot nanda-prbot dismissed their stale review October 26, 2021 12:46

Additional review is required

@nanda-prbot
Copy link

This PR requires additional review because of new changes

Please get another domain review from @samandmoore, or another reviewer with write access if unavailable.

@samandmoore
Copy link
Member

domainlgtm

Copy link

@nanda-prbot nanda-prbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! 🍟 🙌 👯

@CelticMajora CelticMajora merged commit 852bbd7 into main Oct 26, 2021
@CelticMajora CelticMajora deleted the improve-readme-1 branch October 26, 2021 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add details to README
3 participants