Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Switch to analyzer that annotates on the PR #30

Merged
merged 6 commits into from Jan 12, 2022

Conversation

CelticMajora
Copy link
Contributor

📰 Summary of changes

Switches out our analyze step for one produces by invertase that will annotate the issues on the PR itself

https://github.com/invertase/github-action-dart-analyzer

Reviewers

/domain @Betterment/better_test_reporter-maintainers
/no-platform

@nanda-prbot
Copy link

Needs somebody from @Betterment/better_test_reporter-maintainers to claim domain review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

2 similar comments
@nanda-prbot
Copy link

Needs somebody from @Betterment/better_test_reporter-maintainers to claim domain review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

@nanda-prbot
Copy link

Needs somebody from @Betterment/better_test_reporter-maintainers to claim domain review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

@github-actions
Copy link

LCOV of commit 45d8fd8 during CI #53

Summary coverage rate:
  lines......: 94.5% (172 of 182 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@nanda-prbot
Copy link

Needs somebody from @Betterment/better_test_reporter-maintainers to claim domain review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

@samandmoore
Copy link
Member

<<domain tafn

@nanda-prbot
Copy link

@CelticMajora needs to incorporate feedback from @samandmoore. Bump when done.

HOW TO: Resolve Feedback

4 similar comments
@nanda-prbot
Copy link

@CelticMajora needs to incorporate feedback from @samandmoore. Bump when done.

HOW TO: Resolve Feedback

@nanda-prbot
Copy link

@CelticMajora needs to incorporate feedback from @samandmoore. Bump when done.

HOW TO: Resolve Feedback

@nanda-prbot
Copy link

@CelticMajora needs to incorporate feedback from @samandmoore. Bump when done.

HOW TO: Resolve Feedback

@nanda-prbot
Copy link

@CelticMajora needs to incorporate feedback from @samandmoore. Bump when done.

HOW TO: Resolve Feedback

@CelticMajora
Copy link
Contributor Author

bump nanda

@nanda-prbot
Copy link

Needs @samandmoore to provide domain review

When you finish a round of review, be sure to say you've finished or sign off on the PR, e.g.:

TAFN or DomainLGTM

If you're too busy to review, unclaim the PR, e.g.:

@myname >> domain

HOW TO: Give Feedback

@nanda-prbot
Copy link

Needs @samandmoore to provide domain review

When you finish a round of review, be sure to say you've finished or sign off on the PR, e.g.:

TAFN or DomainLGTM

If you're too busy to review, unclaim the PR, e.g.:

@myname >> domain

HOW TO: Give Feedback

@samandmoore
Copy link
Member

@CelticMajora I just pushed up a test commit with issues to see what it looks like 😄

@samandmoore
Copy link
Member

domainlgtm

okay it seems to work well! I'm into it

@samandmoore
Copy link
Member

okay!

domainlgtm

I reverted my commits in the wrong order 😮‍💨 so I fixed it

@github-actions
Copy link

LCOV of commit 7ac2551 during CI #57

Summary coverage rate:
  lines......: 94.5% (172 of 182 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@CelticMajora CelticMajora merged commit 7243517 into main Jan 12, 2022
@CelticMajora CelticMajora deleted the enhance-ci-analyzer branch January 12, 2022 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants