Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update dependencies 9/22 #41

Merged
merged 4 commits into from Sep 14, 2022
Merged

chore: Update dependencies 9/22 #41

merged 4 commits into from Sep 14, 2022

Conversation

CelticMajora
Copy link
Contributor

馃摪 Summary of changes

Updates the following:

  • dart sdk to 2.18.1
  • build_runner to 2.2.1
  • freezed to 2.1.0
  • json_serializable to 6.3.2
  • lints to 2.0.0
  • test to 1.21.6
  • args to 2.3.1
  • freezed_annotation to 2.1.0
  • json_annotation to 4.6.0
  • pub_semver to 2.1.1
  • xml to 6.1.0

馃И Testing done

Kept with existing tests to verify output was unchanged

@CelticMajora CelticMajora requested a review from a team September 14, 2022 17:14
@CelticMajora CelticMajora self-assigned this Sep 14, 2022
@CelticMajora
Copy link
Contributor Author

/no-platform

@github-actions
Copy link

LCOV of commit b6034c6 during CI #78

Summary coverage rate:
  lines......: 95.6% (172 of 180 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@github-actions
Copy link

LCOV of commit d121749 during CI #79

Summary coverage rate:
  lines......: 95.6% (172 of 180 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

btrautmann
btrautmann approved these changes Sep 14, 2022
View reviewed changes
Copy link

@btrautmann btrautmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

domain lgtm

.github/workflows/ci.yml
@@ -38,7 +38,7 @@ jobs:
run: ./tool/generate_code_coverage.sh

- name: Report code coverage
uses: zgosalvez/github-actions-report-lcov@v1.4.0
uses: zgosalvez/github-actions-report-lcov@v1.5.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bonus points if we get this bad boy on Codecov! I think this is the last OSS project (in the mobile realm) not yet using it 馃憖 Could be wrong though...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can do in follow up PR

@CelticMajora CelticMajora merged commit a474abc into main Sep 14, 2022
@CelticMajora CelticMajora deleted the donoho/update-dependencies-9-22 branch September 14, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btrautmann btrautmann btrautmann approved these changes

Assignees

@CelticMajora CelticMajora

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CelticMajora @btrautmann