Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pana): fix pana warnings #6

Merged
merged 4 commits into from Dec 15, 2021
Merged

fix(pana): fix pana warnings #6

merged 4 commits into from Dec 15, 2021

Conversation

samandmoore
Copy link
Member

📰 Summary of changes

What is the new functionality added in this PR?

🧪 Testing done

What testing was added to cover the functionality added in this PR
automated.

Reviewers

/domain @CelticMajora @caffeineflo @btrautmann
/no-platform

@github-actions
Copy link

LCOV of commit 5948873 during CI #20

Summary coverage rate:
  lines......: 95.1% (77 of 81 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

this makes it so that commonly accessed things like headers, body,
method, path, etc are available directly on the CharlatanHttpRequest
instead of via request.requestOptions
@github-actions
Copy link

LCOV of commit a59968c during CI #21

Summary coverage rate:
  lines......: 89.5% (77 of 86 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

⛔ The code coverage is too low. Expected at least 90.

@github-actions
Copy link

LCOV of commit f2c899d during CI #22

Summary coverage rate:
  lines......: 95.3% (82 of 86 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@CelticMajora
Copy link
Contributor

<< domain lgtm 🎉

@samandmoore samandmoore merged commit 5788e27 into main Dec 15, 2021
@samandmoore samandmoore deleted the sam-pana branch December 15, 2021 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants